Commit Graph

878 Commits

Author SHA1 Message Date
ajaybalakumar
a8ec8e5544 Custom Filter refreshed in management page - #916 (#970)
* Custom Filter refreshed in management page

Add, modify and remove events handled for custom filter and the
management page is updated acordingly

Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com>

* Custom Filter refreshed in management page - #916

Review comments fixed.

Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com>
2020-06-18 11:28:36 +02:00
Dominic Schabel
f95be2439d Broken Quartz link fixed #962
Signed-off-by: Dominic Schabel <dominic.schabel@bosch.io>
2020-04-29 18:50:45 +02:00
Shruthi Manavalli Ramanna
21a36a8bce Re-arranged the notification to indication user of already assigned ds (#956)
Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
2020-04-16 13:39:21 +02:00
AnbazhakanSubramaniam
6df1e934ee Allow to download an artifact from the UI (#786) (#944)
This feature allows to download the artifact from the Artifact details
table

Review points are handled

Signed-off-by: usb1cob <Anbazhakan.Subramaniam@in.bosch.com>
2020-04-09 14:51:55 +02:00
amic
793227e501 Fix treshold column headers (#951)
* Adapt header of error treshold column to make it more understandable

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Adapt header of error treshold column to make it more understandable

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
2020-03-23 16:43:28 +01:00
Natalia Kislicyn
83161ea267 Show username in tables (#946)
* formatting the username is slightly improved

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>

* formatting the username without steams

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>

* formatting the username without information about first or last name

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch.io>
2020-03-17 08:01:22 +01:00
amic
2dc5a959f0 Fix xss remained parts (#947)
* Fix remained XSS related tooltips by disabling them
* Adding TODOs to tooltips which has been set to null because of XSS
* Removing TODOs because of SonarQube

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
2020-03-17 07:53:32 +01:00
Natalia Kislicyn
b1497a6f0f Configure logoutHandler and logoutSuccessHandler as Beans (#938)
* Keep the given query parameter when redirecting the login url

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Make logout endpoint configurable via properties;
Undo query parameter acceptance when redirecting the login url

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* make logout base variable non static

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Redo query parameter acceptance when redirecting the login url

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Remove tenant redirection in RedirectController

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Configure logoutHandler and logoutSuccessHandler with Beans

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Undo logout endpoint configuration via properties;

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* remove authenticationEntryPoint configuration; fix review issues

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* adopt review comments

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
2020-03-04 17:13:54 +01:00
Michael Herdt
9e715c292c Read tenant configuration value from system context to prevent permission issues while loading the rollouts view. (#937)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2020-02-20 13:44:36 +01:00
Michael Herdt
c7e910c9c3 Do not set or read user cookies on login. (#933)
* Do not set or read cookies on login.
* Change import order

Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2020-02-19 09:45:16 +01:00
Michael Herdt
144ebd0f19 Show correct notification message for single and multiple notifications. (#931)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2020-02-19 09:26:01 +01:00
Brandon Schmitt
b5f46b8b5d Make logout Button in dashboard menu context path aware. (#930)
Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>
2020-02-06 10:27:54 +01:00
amic
6c162b2e93 Fix xss vulnerability (#924)
* Fix XSS vulnerability for Distribution Set and Software Module field
* Fix XSS vulnerability for Artifact Details of header in Upload view
* Fix XSS vulnerability in Distribution View Software Module box show artifact details window and fix SonarQube issue
* Fix XSS vulnerability in Upload View Software Module field manage metadata
* Fix XSS vulnerability for Notifications when creating or deleting new or existing Distributions or Software Modules plus adapting error notifications when trying to duplicate
* Fix XSS vulnerability for Distributions View when assigning sm to dist confirmation popup text
* Fix XSS vulnerability for Distributions View modules tab of distribution value of SoftwareModule
* Fix XSS vulnerability for Deployment View assigned tab of target which has risky distribution assigned
* Fix XSS vulnerability in Deployment view action history (of) field and eliminate bugs
* Fix XSS vulnerability bug in Deployment View Action history of field
* Fix XSS vulnerability for Distributions View Module tab as it rendered tool tip
* Fix XSS vulnerability formatting
* Invented some IDs to ease testing regarding XSS vulnerability
* Fix XSS peer review findings
* Fix XSS vulnerability for Distribution Set and Software Module field
* Resolve merge conflicts

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
2020-01-27 14:41:07 +01:00
Sebastian Firsching
835757e93a Sort controller attributes alphabetically (#928)
* Sort controller attributes alphabetically
* Use TreeMap instead of streams to sort controller attributes

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-01-24 13:25:45 +01:00
Dominic Schabel
f3659f0142 List of CQs updated
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-16 12:04:12 +01:00
Dominic Schabel
435ca500f4 Switch to OAuth2 starters + exclude mail-dependency
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-14 15:26:02 +01:00
Brandon Schmitt
1bcced9838 OpenID Connect support (#865)
* Added OpenID Connect support

Utilized Spring Security's OAuth2 respectively OIDC support as another
possibility to manage users and their permissions.

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Document OpenID Connect Support

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Updated license in OidcUserManagementAutoConfiguration.java

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Revert updated license notice and add Kiwigrid license file

This reverts commit 23d36245

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Resolve SonarQube issues

- Explicitly import the needed specific classes
- Document public methods
- Add `static` to the constant `JwtAuthoritiesOidcUserService.INVALID_REQUEST`
- Remove superfluous runtime exception `OAuth2AuthenticationException`

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Add OidcUser support in SpringSecurityAuditorAware

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Secure Management API using OpenID Connect, too.

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>
2020-01-14 13:09:13 +01:00
Sebastian Firsching
5feb5873c4 Feature mgmtapi add sha256 to softwaremodules (#918)
* Add sha256 hash to softwaremodules in mgmt api

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Adapt rest docs

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Edit comments

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add proper license header

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-01-13 12:36:14 +01:00
Michael Herdt
0e9caf3a88 Move the refresh button for the controller attributes to the left to … (#920)
* Move the refresh button for the controller attributes to the left to prevent overlay with scrollbar.
* Move the controller attributes refresh button to a separate column.

Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2020-01-13 11:25:16 +01:00
Michael Herdt
e815873dad Check only DELETE_TARGET permission by validating delete permissions for TargetTable (#909)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2019-11-26 12:53:02 +01:00
Bondar Bogdan
f295a98314 changed PageRequest to OffsetBasedPageRequest for all of the Bean Queries (#912)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>
2019-11-18 11:05:35 +01:00
Nazife Basbaz
ab009b2b4b Make constructor of JpaSoftwareModuleManagement and JpaSoftwareModuleTypeManagement public to allow bean overrides (#913)
* set constructor to public
* fix typo
* add exception-message for localisation
* log exception

Signed-off-by: Nazife Basbaz <nazife.basbaz@bosch-si.com>
2019-11-15 09:20:49 +01:00
Michael Herdt
e731585c45 Explain the toggle behavior in JavaDoc better. (#911)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2019-11-13 12:59:18 +01:00
Alexander Dobler
51982a77e3 Fixed error message not shown when exceeding filesize (#906)
* Fixed message not showing when exceeding filesize

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Also use fixed max filesize approach during drag and drop

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Moved log messages and adjusted upload log levels

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Further adjustments of logging

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
2019-11-08 11:11:32 +01:00
Stefan Klotz
9cb5d31396 Prioritisation of assignments via mgmt-API (#895)
* Updating the schema for targetfilterquery and rollout
* Updating the weight validation logic and tests
* Make weight optional
* Fix existing multi assignment tests by adding weight, remove weight from TargetFilterQuery
* Add weight validation tests, fix tests
* Add mgmt api tests for assignment and getting action with weight
* Add management layer validation and tests for creating rollouts with weight
* Fix amqp test, add repo level validation to resource tests
* Add weight to rollout mgmt-api and tests
* Add weight to mgmt api target Filter create and update
* Add target filter auto assign weight. disable enforcement of setting a weight in multiassign mode
* Remove ignored tests, fix api doc
* Fix minor findings
* Fix findings
* Remove hardcoded min weight
* Add docu text, fix findings
* Fix api documentation
* Expose weight via DMF
* Expose actions according to weight via ddi
* Fix documentation
* Add method to get actions ordered by weight to deploymentManagement
* Updating the schema for targetfilterquery and rollout
* Updated the indentation
* Updated the helper class, fixed the randomUID in test factory
* Updated the class name with prefix JPA
* Adding the missing License for WeightValidationHelper class
* Adding documentation to the dmf api on weight
* Removed the merger markers
* Updated the class name
* Removed the redundant method
* Addressed final PR comments
* Updated the missing testcase with latest default weight value
* Reverting the default value of weight back to 1000 and updated tests

Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-11-08 10:47:35 +01:00
Alexander Dobler
09f2d8a481 Fix upload quota check and provide better error message (#893)
* Adjusted upload quota check to include file size and show proper error message

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Fixed failing upload quota tests

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Moved quota check to stream, fixed review findings

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Added missing license header to QuotaInputStream

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Reworked uploadLock, ensured error messages may be translated, review fixes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Added local artifactrepo to gitignore

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Fixed sonar issues and assignment quota message

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* PR review fixes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Split quota exceptions, PR fixes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Removed left over conversion method in quota helper

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Made conversion helper class final

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
2019-10-30 11:24:33 +01:00
Stefan Klotz
8687510131 Assign multiple distribution sets to a target via mgmt api (#886)
* Add multiassignment to mgmt api target endpoint
* Remove single assignment ds to targets offline
* Fix tests
* Add quota for maxResultingActionsPerManualAssignment
* Fix assignment with same target or distribution set multiple times in one request
* Log UI error
* Add tests
* Enable single assignment requests with multiple DSs and types
* Remove redundant target to DS assignment methods
* Add tests, fix assignment
* Fix possible nullpointer during target assignment request
* Update api docu
* Clean up deployment management code
* Enforce MaxActions quota for offline assignment
* Fix review findings
* Rename property, add migration into
* Add builder for DeploymentRequest
* Change offline assignment method to accept an assignment list, like online assignment
* Fix PR findings

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-09-17 14:20:26 +02:00
Ahmed Sayed
a85dafaad5 Added localization to String.format (#857)
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
2019-09-02 08:45:14 +02:00
Anand Kumar
e841dc6a8a Security fix for UI auto refresh (#885)
Signed-off-by: Anand Kumar <anand.kumar@bosch-si.com>
2019-08-21 11:05:36 +02:00
Ahmed Sayed
d40b11d2ab introduced open actionIds in MgmtTargetAssignmentResponseBody (#864)
* introduced open actionIds in MgmtTargetAssignmentResponseBody

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed SonarQube issues

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* removed unused method parameter

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* updated documentation tests

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* added limit to the alreadyAssignedActions in the AssignmentResult

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* moved alreadyAssignedActions limitation to MgmtDistributionSetMapper

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* removed alreadyAssignedActions

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed sonarQube issues

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed compilation error

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed PR review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed PR review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* Renamed AssignmentResult to AbstractAssignmentResult

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed formatting

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* reverted method visibility

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
2019-08-20 11:31:20 +02:00
Markus Block
2b5b8b4a63 Remove dependency to Vaadin addon tokenfield (#875)
* Removed vaadin Tokenfield dependency

Implemented own Tokenfield, but not finished yet. This branch is not
intended to be merged!!!

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* added Combobox and get it running

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Fixed remaining problems, added Combobox for tag selection

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* fixed permission check

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* fixed tag update

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Changed Tag assignment in details tab

Removed assign button and assign a tag when it is selected. In tables
only refreshFilter when necessary.

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* fixed Bulkupload

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Making Sonar happy

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Making Sonar happy

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Fixed Bug in DistTokenfield and sorted Tags in Tag list

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Making Sonar happy

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Fixed Sonar issues

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Implemented code review remarks

Signed-off-by: Markus Block <markus.block@bosch-si.com>
2019-08-13 11:19:19 +02:00
AnbazhakanSubramaniam
d76188a382 Default sort order for targets and rollouts (ref #764) (#874)
* Default sort order for targets and rollouts (ref #764)

The default sort order has been change in order to show the newest
targets and rollouts are always on the top.

* Review Point handled : TARGET_TABLE_CREATE_AT_SORT_ORDER has been
removed

Signed-off-by: Anbazhakan Subramaniam <Anbazhakan.Subramaniam@in.bosch.com>
2019-08-01 09:13:59 +02:00
Robert Sing
61378b1f5c fixed NullPointerException in deployment view (#871)
* fixed NullPointer exception in deployment view

Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>

* fixed review findings

Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
2019-07-31 09:29:23 +02:00
Natalia Kislicyn
3b15e80e95 Bugfix NPE in target percentage (#819)
* Fixed NullPointerException in groups validation callback

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
2019-06-06 08:21:28 +02:00
Nazife Basbaz
fde0cbdf16 fix bug: change sql-query in localArtifactRepository (#820)
Also-by: Nazife Basbaz <nazife.basbaz@bosch-si.com>
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
2019-06-05 16:07:07 +02:00
Dominic Schabel
e6146fa55e Sonar issue fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-05-24 11:40:41 +02:00
Dominic Schabel
509693d0ae Sonar issue fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-05-24 11:14:31 +02:00
Dominic Schabel
c88e7bb06e Sonar issues fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-05-23 19:48:34 +02:00
Bondar Bogdan
d5c373e420 fixed conditions evaluations, that always resulted in true (#844)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>
2019-05-23 09:12:41 +02:00
Stefan Klotz
d34e7f35c5 remove localization from DistributionBar html class (#842)
Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-05-17 15:12:49 +02:00
Stefan Behl
b50515367e Deployment View broken with Access Denied error (#841)
* Use SystemSecurityContext:runAsSystem to fix AccessDeniedException

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>
2019-05-17 08:41:08 +02:00
Stefan Behl
1ac40a7a95 Support for Multi-Assignments (#833)
* First draft of new assignment logic

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Enhancements of System Configuration view

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Drag&drop enhancements for multiple distribution set assignments

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Misc fixes

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* test that previous assignments are not canceled

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* add description and expected events to test

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* extend TenantConfigurationManagement by NullPointerException proof
getConfigurationValue method

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Hide "Required Migration Step" if Multi Assignments is enabled

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Make fields transient

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Add IDs for Required Migration Step elements

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Save work in progress

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Added new DMF message DmfMultiActionRequest

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* DMF enhancements to send out MultiActionRequest messages

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Minor changes

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Multi Assignment support for cancellations

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* fix permission problems and immutable lists

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* add message dispatcher tests for outgoing multiassignment messages, fix
old tests

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Implement Multi-Assignment support for rollout groups

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Minor changes

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Refactoring

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Register new deployment event with protobuff framework

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Allow same DS to be assigned multiple times

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix assignment with pending cancellations

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Reduce repository /DB calls

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Revert latest perf fix (causing a regression)

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* test if a rollout sends multiaction messages in multiassignment mode

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Minor changes

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Do not close new action if DS is already assigned (if multi-assign on)

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* add test that starts and finishes multiple rollouts in multiassignt mode

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* add javadoc to test method

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Prevent Multi-Assignments from being disabled via Repo Config UI

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Add link to Provisioning State Machine

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* test that Multiassignment can not be disabled via mgmt-api

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* refactor AmqpMessageHandlerService code

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Prevent Multi-Assignments feature from being disabled via Mgmt REST API

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* add license header, remove unused instance variables

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* fix tenantConfigurationManagement mock in test

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* return empty list instead of null

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* add ddi test for multiassignment, fix old test

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Prevent autoclose from being modified if Multi-Assignments is enabled

# WARNING: head commit changed in the meantime

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Add test for autoClose /multiAssign

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Javadoc improvements

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* change test method that waits for dmf messages to be dispatched

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* clean up code

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* Fix UI-related PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings, Sonar issues, and test failures

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix Sonar findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* Fix PR review findings

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>
2019-05-16 10:30:40 +02:00
Stefan Behl
f16f986eed Auto-Assignment link missing in Target Filter view (caused by NPE in TargetFilterTable) (#835)
* Add fallback to ActionType.FORCED for auto assignment filters

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* add comment

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>

* improve javadoc

Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>
2019-05-09 17:09:35 +02:00
Jeroen Laverman
b4ec3478c4 Fix localisation in System Configuration View (#822)
* Fix localisation:
* Regenerate Key
* SSL Issuer Hash
* Rollouts Tooltip

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* add final

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* add parameter description

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* Review findings

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* remove TODO-ID

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>
2019-05-06 13:47:02 +02:00
Ahmed Sayed
ed95ae6398 Feature download only (#810)
* Added initial version of DOWNLOAD_ONLY
* Added DOWNLOAD_ONLY option to ActionTypeOptionGroupLayout
* Removed DOWNLOAD_ONLY checkbox, added Download Only UI option
* Mark actions that finished with DOWNLOADED as finished
* initial changes to realize downoadOnly in UI
* Changed method of disabling maintenanceWindow into smarter solution
* Added new icon for download only option
* Set DistributionSet as unassigned when DOWNLOAD_ONLY
* Enabled update action status for DOWNLOAD_ONLY after download
* Current state of abstraction task
* Assign DistributionSet to target if target installs it after downloading
* Abstracted class redundant methods
* Added tests
* Fixed Rollout finish status for DWONLOAD_ONLY Rollouts
* Added Rollout type json property in test documentation
* Added DOWNLOAD_ONLY test for target assignment
* Added event listener also to DistributionTable
* Fixed event listener problem
* Change column name to "Type" and added also DownloadOnly icon to that column.
* Cleanup
* Center aligned the icons in type column
* Fixed DistributionSet already assigned but not installed
* Rename download_only to downloadonly
* Further changes regarding center aligned the icons
* Fixed target assign status in Rollout view when download_only
* Fixed SonarQube issues
* Fixed SonarQube issues + code formatting
* Fixed Tests
* Marked squid:S128 as suppressed - irrelevant
* Adapting rollouts view by additional column (not finished by now)
* Putted type column on proper position
* Trying to display icons in new type column in rollouts view
* Added icon also for soft, icon might change -> just change
* createOptionGroup method in ActionTypeOptionGroupLayout class
* added first draft of type column in rollouts view
* increase visibility of sendUpdateMessageToTarget method
* Ground functionality of new type column in deployment view is now implemented
* Type column implementation in rollouts view is finished for now
* Rebased on master
* Fixed DurationControl change on ScheduleControl change.
* (Re)Added Soft deployment Icon
* Fixed SonarQube issues
* Fixed SonarQube issues
* Fixed failing test
* Fixes + added missing header
* Added message to the fail() instruction
* Fixed copyright header
* Apply suggestions from code review
* Fixed TotalTargetCountStatus.java
* Removed unused method from TotalTargetCountStatus.java
* add id to rollout create and update UI popup
* Added download_only tests for MgmtTargetResourceTest.java
* added missing header in TotalTargetCountStatusTest.java
* Rename because of newest changes
* added Download_Only dmf integration tests
* Renamed MgmtAction.forcedType to actionType
* renamed actionType to forceType for Mgmt API
* added missing javadocs for public methods
* Added Download Only support for AutoAssignment

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
2019-04-17 12:27:23 +02:00
Jeroen Laverman
04b9abda3b Feature fixed timezone (#824)
* Fix typo
* Set fixedTimeZone via properties
* Fix Sonar findings
* Fix review findings
* Rename variable
* Fix logic

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>
2019-04-17 11:09:44 +02:00
Dominic Schabel
191d64cbbc Bumped Spring Boot version to 2.1.4 (#825)
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-04-17 10:54:37 +02:00
Stefan Klotz
3a5776a90d Fix cast exception in UI (#816)
* check type before cast

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>

* use collection instead of set

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-04-02 13:24:53 +02:00
Stefan Klotz
0a3f1a2b7a fix increase notification visibility time (#808)
Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-03-15 09:29:33 +01:00
Stefan Klotz
75f66c9811 Fix localization vaadin system messages (#807)
* Add customized SystemMessagesProvider
* Localize according to SystemMessagesInfo
* Localize vaadin 'Server connection lost' message
* Use available locale for system messages
* Add license header
* Fix PR findings
* Fix Sonar issues

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-03-14 12:43:47 +01:00