Commit Graph

66 Commits

Author SHA1 Message Date
Fabian Nonnenmacher
c39753001e Bugfix: Setting and getting configuration values
- removed cache from global getter, because it was overriding the cache of
  the tenant specific getter
- changed Type of AuthName key, type of key was not important before the huge
  configuration refactoring
- fixed test conditions

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:17:28 +01:00
Fabian Nonnenmacher
6a88f2a3f4 Added Permission for TenantConfiguration changes
- created SpringEvalExpression for the right to change tenant configuration
- added this authorization filter to every tenant configuration related method

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:17:13 +01:00
Fabian Nonnenmacher
ec79e9bd19 Added REST interfaces for tenant configuration
- added GET, DELETE and PUT function on configuration value interfaces
- changed Exception in TenantConfigurationManagement for correct mapping to HTTP Status
- added function to get global configurations from TenantConfigurationManagement, to have
  only one class for handling these configuration values

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:16:57 +01:00
Fabian Nonnenmacher
4be880587a Added validation before saving TenantConfiguration and updated tests
* run the validation methodes inside the storing methode, to make sure that only
  valid values are written inside the database
* updated TenantConfigurationManagementTest to match the validation
* added new Tests to test all validators

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:16:42 +01:00
Fabian Nonnenmacher
a5a0dc17f6 Removed PollConfigurationHelper and not used Exceptions
- removed PollConfigurationHelper and coresspending test, because it was replaced by TenantConfigurationManagement
- removed very specific configuration exceptions, because they are not needed anymore

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:16:13 +01:00
Fabian Nonnenmacher
49486755b2 Revert "changed datamodel, integrated poll configuration into tenant meta data table"
This reverts commit 9d147aada710cc2333723604fa8893e4f2f0515f.

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>

Conflicts:
	hawkbit-core/src/main/java/org/eclipse/hawkbit/ControllerPollProperties.java
	hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TenantMetaData.java
2016-02-29 13:15:59 +01:00
Fabian Nonnenmacher
6cef6aed1a Moved tenant configuration functions to new management class
- moved fucntions to TenantConfigurationManagement, for better function capseling
- updated references
- updated references in tests, tests were succesfully

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:15:40 +01:00
Fabian Nonnenmacher
b56477191a Added generic validator fucntion to TenantConfigurationKey
Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:15:27 +01:00
Fabian Nonnenmacher
3f2c0d134a Updated UI to use new database structure
* use new methods to store polling Configuration
* refactored DurationConfigField, added Builder

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:15:14 +01:00
Fabian Nonnenmacher
07fce42469 Changed return type of SystemManagement.getConfigurationValue()
* changed Return type to wrapper object, adding additional meta data stored in the database
* updated all calls of this method
* updated function calls in tests
* verified correct execution of correspending tests

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:15:03 +01:00
Fabian Nonnenmacher
f3fa085c62 First implemtation of REST-API
Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:14:36 +01:00
Fabian Nonnenmacher
088df73ea9 Refactoring of buisness logic
* added DurationHelper to have access to Convertion in every class
* removed tenant specific getter and setter from PollConfigurationHelper
* changed getter and setter in TenantMetaData to use DurationObjects instead of Strings
* updated UI to call new functions
* updated module tests

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:14:21 +01:00
Fabian Nonnenmacher
3f451537cf Added tests for PollConfigurationHelper
Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:13:44 +01:00
Fabian Nonnenmacher
cb3e6863c1 Updated UI to handle all requirements
* added DurationConfigField (Field which contains a DurationConfigField and a Checkbox)
* added labels to messages.properties
* added new Interface ConfigurationElement, with functionallity which is important for saving the data

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:13:31 +01:00
Fabian Nonnenmacher
1eedd3a531 Implemented Buisnesslogic to read and save correct polling configuration
- added min and max values to config files
- updated ControllerPollProperties: added getter and setter of min and max values
- updated PollConfigurationHelper: added getter for different values

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:13:12 +01:00
Fabian Nonnenmacher
07e0fb3032 First Implemantation of Configuration Logic
Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:09:33 +01:00
Fabian Nonnenmacher
1f9c6bfd72 Changed datamodel, integrated poll configuration into tenant meta data table
* updated sql scripts to update new collums
* updated coressponding JPA class TenantMetaData

Signed-off-by: Nonnenmacher Fabian <fabian.nonnenmacher@bosch-si.com>
2016-02-29 13:09:19 +01:00
Kai Zimmermann
e95acec956 Merge pull request #52 from bsinno/REFACTORING_CLEAN_CODE_PART_2
👍 merged
2016-02-26 09:50:43 +01:00
Michael Hirsch
62d96a4ac6 remove static modifier from inner class
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-25 14:51:45 +01:00
Michael Hirsch
f969d6f4c2 clean code refactorings
- add description to assertions in unit tests
- make inner classes static
- remove out-commented code

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-25 14:38:25 +01:00
SirWayne
dbf03dca12 Add the "@Override" annotation
Add some description to JUnit Tests
Remove unused override comments
Remove unused javadoc on private methode

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-25 11:37:56 +01:00
SirWayne
fcd6555e3e Fix diamond operator
Remove unused override comments
Remove unused javadoc on private methode

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-24 18:24:53 +01:00
Kai Zimmermann
13345406ee Upgraded 3rd party libs 2016-02-22 11:01:47 +01:00
Kai Zimmermann
b6509750bc Removed broken javadoc.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-18 10:22:21 +01:00
Kai Zimmermann
1c6223ba5d Improved readibility
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-18 10:12:36 +01:00
Kai Zimmermann
01b75fc932 Removed unnecessary entitygraph usage.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-17 09:57:07 +01:00
Kai Zimmermann
3334cf4a64 Updated test
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-17 08:36:36 +01:00
Kai Zimmermann
6a2b74e565 Enabled target.assignedDs load through action enitygraph.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-16 17:37:34 +01:00
Kai Zimmermann
38b750f674 DistributionSetAssignmentResult contains actions that do not reflect the
status on the DB. Needs to be avoided by returning actions IDs only and
force the user to query an updated action entity.

Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-16 17:37:06 +01:00
Michael Hirsch
2ef04bb437 Merge pull request #41 from bsinno/custom-target-filter-bug-fixes
👍 ok merging.
2016-02-15 13:13:30 +01:00
Michael Hirsch
7b79010fbf format sources with correct formatter.
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-15 12:32:12 +01:00
Michael Hirsch
21114a731d Merge pull request #42 from bsinno/EMPTY_CONTROLLER_ID
👍 is ok merging.
2016-02-15 12:11:41 +01:00
asharani-murugesh
a0a24376bb Revert to master copy
Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-15 10:43:07 +01:00
asharani-murugesh
158a9cfa20 RSQLUtility : convert query to lower case before parsing
Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-15 10:38:30 +01:00
Michael Hirsch
8e0c345bf2 Merge pull request #40 from bsinno/clean_code_add_description_to_junit_test
👍  is ok merging.
2016-02-15 08:57:25 +01:00
asharani-murugesh
59fb97fea2 In and Out parameter changes
Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-13 21:33:27 +01:00
asharani-murugesh
aac43d346f Bug fixes:
Custom filter detail view : Using =IN= parameter throws 'Unsupported
operator' exception and breaks the UI
Custom filter search : type any query.Search never gets finished.
Alloe case insensitive search for IN paramters

Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-13 12:21:04 +01:00
Kai Zimmermann
c7254d665e Merge pull request #38 from bsinno/fix_wrong_count_select_statement_for_targetrolloutgroup
👍 ok
2016-02-12 15:57:48 +01:00
Jonathan Philip Knoblauch
88c854f2be Clean code for junit tests …
- Added messages to JUnit assertions
- Added Description when missing
- Changed to assertThat when assertEquals

Signed-off-by: Jonathan Philip Knoblauch <JonathanPhilip.Knoblauch@bosch-si.com>
2016-02-12 13:47:53 +01:00
Michael Hirsch
e2927acfca reduce logging from info to debug when checking rollout
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-12 13:18:55 +01:00
Michael Hirsch
b30375e9e6 fix count select statement join is wrong
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-12 12:36:12 +01:00
SirWayne
46a71c1b3a Use javax annotation for validation
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-10 16:51:45 +01:00
SirWayne
f78bd68c03 Verify that the target controller id cannot be empty
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-10 16:22:20 +01:00
SirWayne
b21f8f5c71 Clean Code Refactoring
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-09 13:36:58 +01:00
SirWayne
ceb23e65e4 Remove this for member variable
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-09 11:29:01 +01:00
SirWayne
1bb29338ac Clean Code Refactoring
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-09 10:16:07 +01:00
SirWayne
9ae2ef0bc0 Merge remote-tracking branch 'origin/code_style_sonar_rule_fixes' into Sonar_Fix_Rollout 2016-02-08 08:47:52 +01:00
SirWayne
4574c78908 Add SpecificationBuilder to avoid duplicate code
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-08 08:47:12 +01:00
Michael Hirsch
2a45fab9d7 make immediately return statement, not storing into local variable.
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-08 08:46:50 +01:00
Michael Hirsch
a488a42cc9 code sonar rule cleanup of DistributionSetManagament
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-05 16:01:25 +01:00