Commit Graph

2276 Commits

Author SHA1 Message Date
Sebastian Firsching
87eadf59cd Reduce log output for entity not found in AmqpAuthenticationMessageHandler (#929)
* Reduce log output for entity not found in AmqpAuthenticationMessageHandler

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Adapt tests for reduced log message

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Suppress sonar warning + change log level for EntityNotFound

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-02-18 11:29:41 +01:00
Brandon Schmitt
b5f46b8b5d Make logout Button in dashboard menu context path aware. (#930)
Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>
2020-02-06 10:27:54 +01:00
amic
6c162b2e93 Fix xss vulnerability (#924)
* Fix XSS vulnerability for Distribution Set and Software Module field
* Fix XSS vulnerability for Artifact Details of header in Upload view
* Fix XSS vulnerability in Distribution View Software Module box show artifact details window and fix SonarQube issue
* Fix XSS vulnerability in Upload View Software Module field manage metadata
* Fix XSS vulnerability for Notifications when creating or deleting new or existing Distributions or Software Modules plus adapting error notifications when trying to duplicate
* Fix XSS vulnerability for Distributions View when assigning sm to dist confirmation popup text
* Fix XSS vulnerability for Distributions View modules tab of distribution value of SoftwareModule
* Fix XSS vulnerability for Deployment View assigned tab of target which has risky distribution assigned
* Fix XSS vulnerability in Deployment view action history (of) field and eliminate bugs
* Fix XSS vulnerability bug in Deployment View Action history of field
* Fix XSS vulnerability for Distributions View Module tab as it rendered tool tip
* Fix XSS vulnerability formatting
* Invented some IDs to ease testing regarding XSS vulnerability
* Fix XSS peer review findings
* Fix XSS vulnerability for Distribution Set and Software Module field
* Resolve merge conflicts

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
2020-01-27 14:41:07 +01:00
Sebastian Firsching
62c876a435 Fix empty controller name (#925)
* Truncate target name when name is empty and controllerId exceeds name length limit
* Add check if controllerId is null
* Use seperate method to truncate controllerId + use Array.asList to create list
* Make truncateControllerIdToMaxNameLength a static method
* Additionally check target name by calling target management

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-01-27 13:09:43 +01:00
Sebastian Firsching
835757e93a Sort controller attributes alphabetically (#928)
* Sort controller attributes alphabetically
* Use TreeMap instead of streams to sort controller attributes

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-01-24 13:25:45 +01:00
Dominic Schabel
4969bf3eb7 Add Stack Overflow as communication channel (#926)
* Stack Overflow added as communication channel

Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>

* Wording improved

Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-22 10:24:57 +01:00
Jeroen Laverman
53345d9f2f Add Docker for M6 (#927)
* Add docker for M6

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* update generator

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* update versions

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* fix version

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>

* update Java

Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>
2020-01-21 17:42:05 +01:00
Dominic Schabel
16bb59c9a9 0.3.0M6 added to release notes
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-21 13:53:45 +01:00
Dominic Schabel
f3659f0142 List of CQs updated
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-16 12:04:12 +01:00
Dominic Schabel
435ca500f4 Switch to OAuth2 starters + exclude mail-dependency
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-14 15:26:02 +01:00
Dominic Schabel
df21a63ee3 Sonar issues from PR #865 fixed
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-14 14:29:20 +01:00
Dominic Schabel
67ecd875a7 Put back CORS config
+ minor formatting

Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-14 13:25:53 +01:00
Brandon Schmitt
1bcced9838 OpenID Connect support (#865)
* Added OpenID Connect support

Utilized Spring Security's OAuth2 respectively OIDC support as another
possibility to manage users and their permissions.

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Document OpenID Connect Support

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Updated license in OidcUserManagementAutoConfiguration.java

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Revert updated license notice and add Kiwigrid license file

This reverts commit 23d36245

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Resolve SonarQube issues

- Explicitly import the needed specific classes
- Document public methods
- Add `static` to the constant `JwtAuthoritiesOidcUserService.INVALID_REQUEST`
- Remove superfluous runtime exception `OAuth2AuthenticationException`

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Add OidcUser support in SpringSecurityAuditorAware

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>

* Secure Management API using OpenID Connect, too.

Signed-off-by: Brandon Schmitt <Brandon.Schmitt@kiwigrid.com>
2020-01-14 13:09:13 +01:00
Dominic Schabel
38017ba7bc Temporarily removed CORS config
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2020-01-14 13:06:36 +01:00
Sebastian Firsching
8d3ba68be9 Fix already assigned targets (#919)
* Dont count not existing targets as already assigned to DS

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add test for deploymentManagement

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Delete 404 error message from docs when target is not found

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add text to implementation notes

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add assertions to test

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add expected behaviour to test description

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Refactor deploymentMgmtTest

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Filter out non-existing controllerIds

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Extend test descriptions

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Refactor createTargets method

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add createTargetAndJsonArray method

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Correct expected test result

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Adapt rest docs

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Correct test

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Only count targets that exist for total and adapt test

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Use only existign targetWithActionTypes for assignment

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Rename targetIds to providedTargetIds

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-01-13 12:41:59 +01:00
Sebastian Firsching
5feb5873c4 Feature mgmtapi add sha256 to softwaremodules (#918)
* Add sha256 hash to softwaremodules in mgmt api

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Adapt rest docs

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Edit comments

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>

* Add proper license header

Signed-off-by: Sebastian Firsching <sebastian.firsching@bosch-si.com>
2020-01-13 12:36:14 +01:00
Michael Herdt
0e9caf3a88 Move the refresh button for the controller attributes to the left to … (#920)
* Move the refresh button for the controller attributes to the left to prevent overlay with scrollbar.
* Move the controller attributes refresh button to a separate column.

Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2020-01-13 11:25:16 +01:00
Dominic Schabel
d1159ba1a7 Slides for Community Day 2019 added
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-12-03 17:17:03 +01:00
Michael Herdt
e815873dad Check only DELETE_TARGET permission by validating delete permissions for TargetTable (#909)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2019-11-26 12:53:02 +01:00
Bondar Bogdan
f295a98314 changed PageRequest to OffsetBasedPageRequest for all of the Bean Queries (#912)
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>
2019-11-18 11:05:35 +01:00
Nazife Basbaz
ab009b2b4b Make constructor of JpaSoftwareModuleManagement and JpaSoftwareModuleTypeManagement public to allow bean overrides (#913)
* set constructor to public
* fix typo
* add exception-message for localisation
* log exception

Signed-off-by: Nazife Basbaz <nazife.basbaz@bosch-si.com>
2019-11-15 09:20:49 +01:00
Michael Herdt
e731585c45 Explain the toggle behavior in JavaDoc better. (#911)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2019-11-13 12:59:18 +01:00
Michael Herdt
271bcf0fc8 increase the value of maximal targets per auto assigment (#910)
Signed-off-by: Michael Herdt <Michael.Herdt2@bosch-si.com>
2019-11-13 12:56:38 +01:00
Natalia Kislicyn
c0ed1cdfbe Switch Jacoco's code coverage format to XML reports (#882)
* jacoco xml report configuration
+ create exec files per module
+ introduce report aggregation in test report module
+ remove failsafe plugin usage
+ set xml report path for sonar

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* add update-server dependency to test report

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Reorder elements in pom

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* undo surefire / failsafe changes

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* set remote sonar host

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
2019-11-08 15:41:18 +01:00
Alexander Dobler
51982a77e3 Fixed error message not shown when exceeding filesize (#906)
* Fixed message not showing when exceeding filesize

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Also use fixed max filesize approach during drag and drop

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Moved log messages and adjusted upload log levels

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Further adjustments of logging

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
2019-11-08 11:11:32 +01:00
Stefan Klotz
9cb5d31396 Prioritisation of assignments via mgmt-API (#895)
* Updating the schema for targetfilterquery and rollout
* Updating the weight validation logic and tests
* Make weight optional
* Fix existing multi assignment tests by adding weight, remove weight from TargetFilterQuery
* Add weight validation tests, fix tests
* Add mgmt api tests for assignment and getting action with weight
* Add management layer validation and tests for creating rollouts with weight
* Fix amqp test, add repo level validation to resource tests
* Add weight to rollout mgmt-api and tests
* Add weight to mgmt api target Filter create and update
* Add target filter auto assign weight. disable enforcement of setting a weight in multiassign mode
* Remove ignored tests, fix api doc
* Fix minor findings
* Fix findings
* Remove hardcoded min weight
* Add docu text, fix findings
* Fix api documentation
* Expose weight via DMF
* Expose actions according to weight via ddi
* Fix documentation
* Add method to get actions ordered by weight to deploymentManagement
* Updating the schema for targetfilterquery and rollout
* Updated the indentation
* Updated the helper class, fixed the randomUID in test factory
* Updated the class name with prefix JPA
* Adding the missing License for WeightValidationHelper class
* Adding documentation to the dmf api on weight
* Removed the merger markers
* Updated the class name
* Removed the redundant method
* Addressed final PR comments
* Updated the missing testcase with latest default weight value
* Reverting the default value of weight back to 1000 and updated tests

Signed-off-by: Shruthi Manavalli Ramanna <shruthimanavalli.ramanna@bosch-si.com>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-11-08 10:47:35 +01:00
Alexander Dobler
09f2d8a481 Fix upload quota check and provide better error message (#893)
* Adjusted upload quota check to include file size and show proper error message

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Fixed failing upload quota tests

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Moved quota check to stream, fixed review findings

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Added missing license header to QuotaInputStream

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Reworked uploadLock, ensured error messages may be translated, review fixes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Added local artifactrepo to gitignore

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Fixed sonar issues and assignment quota message

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* PR review fixes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Split quota exceptions, PR fixes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Removed left over conversion method in quota helper

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Made conversion helper class final

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
2019-10-30 11:24:33 +01:00
esunea
9b8ab40c55 Adding docker-compose doc (#904)
Signed-off-by: MOULARD Paul <p.moulard@tekin.fr>
2019-10-28 15:46:56 +01:00
Dominic Schabel
80509158eb Fixes #843 (#894)
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-10-25 08:49:01 +02:00
Ammar Bikic
af0f7ceb5a Feature add optional name to thing created (#888)
* First implementation pushed because of debugging purpose

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Add name field and tests regarding name field functionality in THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* SonarQube realted changes in name field functionality in THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Add name field and tests regarding name field functionality in UPDATE_ATTRIBUTES

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Adapt documentation due to name field in THING_CREATED and UPDATE_ATTRIBUTES

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Add integration tests regarding name field functionality in THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Reformat after finding format bug regarding THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Reformat after finding the real format bug regarding THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Reformat regarding THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Use constant in THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Format in THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Resolving peer review comments regarding THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Resolving peer review comments (organize imports) regarding THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Refactoring regarding THING_CREATED

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Refactoring due to peer review

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Refactoring due to peer review

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Excluding UPDATE_ATTRIBUTES changes and provide functionality of updating the name property in THING_CREATED message

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Refactoring due to peer review

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Refactoring due to peer review

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Fix SonarQube finding

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Merge master into current branch

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>

* Fix peer review findings

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
2019-10-24 12:13:35 +02:00
Natalia Kislicyn
b50a82fc0f RabbitMQ listener properties (#899)
* Rename dmf defaults properties to config rabbitmq's simple listener

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* set rabbitmq listener prefetch and concurrency properties

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
2019-10-21 10:59:58 +02:00
Kai Zimmermann
1a0c6cb842 Updated cloud slide. (#902)
Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>
2019-10-21 07:56:56 +02:00
Jeroen Laverman
c7c7f37fb4 Add link to hawkBit sessions of ECE19
Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>
2019-10-19 10:38:52 +02:00
Jeroen Laverman
42700c1e35 Add slides for EclipseCon 2019 Community day (#900)
Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch-si.com>
2019-10-19 10:37:42 +02:00
Robert Sing
b4025f9c27 improved documentation of ddi-rootcontroller resource's links list (#887)
* improved documentation of ddi-rootcontroller resource's links list
* fixed review comments
* improved formatting

Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
2019-10-18 09:32:08 +02:00
Sandeep Ravindranath
ed0f56d0a3 Change constructor visibility of JpaTargetTagManagement to public (#896)
Signed-off-by: Ravindranath Sandeep (INST-IOT/ESW-Imb) <Sandeep.Ravindranath@bosch-si.com>
2019-10-11 15:08:27 +02:00
Natalia Kislicyn
193603282a Introduce new DMF message THING_REMOVED (#891)
* Introduce new DMF message THING_REMOVED

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* rename test to its original name

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* API documentation adapted; constant defined for duplicated string

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Resolve review comments; Replace try/catch blocks in exceptions testing

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Re-add finally block in test cases

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
2019-10-10 14:41:47 +02:00
Stefan Klotz
8687510131 Assign multiple distribution sets to a target via mgmt api (#886)
* Add multiassignment to mgmt api target endpoint
* Remove single assignment ds to targets offline
* Fix tests
* Add quota for maxResultingActionsPerManualAssignment
* Fix assignment with same target or distribution set multiple times in one request
* Log UI error
* Add tests
* Enable single assignment requests with multiple DSs and types
* Remove redundant target to DS assignment methods
* Add tests, fix assignment
* Fix possible nullpointer during target assignment request
* Update api docu
* Clean up deployment management code
* Enforce MaxActions quota for offline assignment
* Fix review findings
* Rename property, add migration into
* Add builder for DeploymentRequest
* Change offline assignment method to accept an assignment list, like online assignment
* Fix PR findings

Signed-off-by: Stefan Klotz <stefan.klotz@bosch-si.com>
2019-09-17 14:20:26 +02:00
Dominic Schabel
dba972423b Fixed wrong Spring version
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-09-03 17:19:45 +02:00
Ahmed Sayed
a85dafaad5 Added localization to String.format (#857)
Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
2019-09-02 08:45:14 +02:00
Robert Sing
9f76f6c371 added missing JsonIgnoreProperties annotation for DDI Api model classes (#881)
* added missing JsonIgnoreProperties annotation for DDI model classes
* added Copyright Headers & serialization tests for all Ddi model classes
* fixed typo in test
* fixed review findings
* added missing test descriptions

Signed-off-by: Robert Sing <Robert.Sing@bosch-si.com>
2019-08-27 09:27:20 +02:00
Anand Kumar
e841dc6a8a Security fix for UI auto refresh (#885)
Signed-off-by: Anand Kumar <anand.kumar@bosch-si.com>
2019-08-21 11:05:36 +02:00
Ahmed Sayed
d40b11d2ab introduced open actionIds in MgmtTargetAssignmentResponseBody (#864)
* introduced open actionIds in MgmtTargetAssignmentResponseBody

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed SonarQube issues

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* removed unused method parameter

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* updated documentation tests

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* added limit to the alreadyAssignedActions in the AssignmentResult

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* moved alreadyAssignedActions limitation to MgmtDistributionSetMapper

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* removed alreadyAssignedActions

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed sonarQube issues

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed compilation error

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed PR review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed PR review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* Renamed AssignmentResult to AbstractAssignmentResult

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed review findings

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* fixed formatting

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* reverted method visibility

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
2019-08-20 11:31:20 +02:00
Ahmed Sayed
973f1952c7 Excluded EntityAlreadyExists exceptions from requeuing (#883)
* excluded EntityAlreadyExists exceptions from requeuing

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* moved the catch clause closer to the thrown exception

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* reverted AmqpMessageHandlerServiceIntegrationTest package change

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* reduced scope of method variable

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>

* removed instantiation of exceptions

Signed-off-by: Ahmed Sayed <ahmed.sayed@bosch-si.com>
2019-08-14 16:59:08 +02:00
Bondar Bogdan
c68c5a6f5b Feature event publishing (#884)
* refactored code to use EventPublisherHolder for publishing application events where possible

Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>

* fixed comment

Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>
2019-08-14 09:08:23 +02:00
Markus Block
2b5b8b4a63 Remove dependency to Vaadin addon tokenfield (#875)
* Removed vaadin Tokenfield dependency

Implemented own Tokenfield, but not finished yet. This branch is not
intended to be merged!!!

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* added Combobox and get it running

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Fixed remaining problems, added Combobox for tag selection

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* fixed permission check

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* fixed tag update

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Changed Tag assignment in details tab

Removed assign button and assign a tag when it is selected. In tables
only refreshFilter when necessary.

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* fixed Bulkupload

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Making Sonar happy

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Making Sonar happy

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Fixed Bug in DistTokenfield and sorted Tags in Tag list

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Making Sonar happy

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Fixed Sonar issues

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Implemented code review remarks

Signed-off-by: Markus Block <markus.block@bosch-si.com>
2019-08-13 11:19:19 +02:00
Dominic Schabel
275c6a5b2e Filed CQs for PR #865
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-08-02 13:36:45 +02:00
Bondar Bogdan
41cbf23c62 Feature dispatcher refactoring (#872)
* added target validation for cancel event, allowed from-self check overriding

Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>

* changed methods visibility

Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>

* made isFromSelf a concrete implementation of shouldBeProcessed generic event method

Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>

* changed log level to warn

Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch-si.com>
2019-08-01 10:19:20 +02:00
Dominic Schabel
f4475780d6 Set constructor to public
Signed-off-by: Dominic Schabel <dominic.schabel@bosch-si.com>
2019-08-01 09:35:55 +02:00
AnbazhakanSubramaniam
d76188a382 Default sort order for targets and rollouts (ref #764) (#874)
* Default sort order for targets and rollouts (ref #764)

The default sort order has been change in order to show the newest
targets and rollouts are always on the top.

* Review Point handled : TARGET_TABLE_CREATE_AT_SORT_ORDER has been
removed

Signed-off-by: Anbazhakan Subramaniam <Anbazhakan.Subramaniam@in.bosch.com>
2019-08-01 09:13:59 +02:00