Commit Graph

63 Commits

Author SHA1 Message Date
Kai Zimmermann
dcea53f4c8 Merge remote-tracking branch 'eclipse/master' into harmonize-test-documentation 2016-03-04 18:14:26 +01:00
Kai Zimmermann
25832e7e16 Merge remote-tracking branch 'eclipse/master' into cleanup-properties
# Conflicts:
#
hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/AmqpProperties.j
ava
2016-03-04 12:11:35 +01:00
Kai Zimmermann
71653470dc Merge remote-tracking branch 'eclipse/master' into harmonize-test-documentation 2016-03-03 20:59:15 +01:00
Kai Zimmermann
794db18673 Added comments and changed default sorting for actions. 2016-03-03 20:46:50 +01:00
Kai Zimmermann
e7173aa846 Cleanup messed up actionstatus sorting. We used sort param but had
hardcoded sorting in the reposirory. I added also reportAt based
sorting.

Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-03-03 18:54:50 +01:00
SirWayne
052d50e98d Merge branch 'Clean_Code' into Multiple_VHost_Connection
Conflicts:
	hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java


Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-03-02 14:14:09 +01:00
SirWayne
c9c36ea435 Add description for asserts in test cases
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-29 15:34:07 +01:00
SirWayne
895a78fee8 Merge branch 'master' into Multiple_VHost_Connection
Conflicts:
	hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java
	hawkbit-security-core/src/test/java/org/eclipse/hawkbit/util/IpUtilTest.java


Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-29 12:41:52 +01:00
Kai Zimmermann
e95acec956 Merge pull request #52 from bsinno/REFACTORING_CLEAN_CODE_PART_2
👍 merged
2016-02-26 09:50:43 +01:00
Kai Zimmermann
7692a29918 Fixed property bean setup 2016-02-25 20:36:17 +01:00
Kai Zimmermann
3eaab83014 Merge remote-tracking branch 'eclipse/master' into cleanup-properties 2016-02-25 18:01:56 +01:00
Kai Zimmermann
ab18e12b69 Completed migration to ConfigurationProperties annotation. Added boot metadata generation to build. 2016-02-25 17:59:46 +01:00
Michael Hirsch
62d96a4ac6 remove static modifier from inner class
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-25 14:51:45 +01:00
Michael Hirsch
f969d6f4c2 clean code refactorings
- add description to assertions in unit tests
- make inner classes static
- remove out-commented code

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-25 14:38:25 +01:00
SirWayne
dbf03dca12 Add the "@Override" annotation
Add some description to JUnit Tests
Remove unused override comments
Remove unused javadoc on private methode

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-25 11:37:56 +01:00
Kai Zimmermann
0b8e693cec Migrated environment aware to property annotation mechanism, documented properties. 2016-02-25 11:36:21 +01:00
SirWayne
fcd6555e3e Fix diamond operator
Remove unused override comments
Remove unused javadoc on private methode

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-24 18:24:53 +01:00
Kai Zimmermann
82121766d1 Merge remote-tracking branch 'eclipse/master' into harmonize-test-documentation
# Conflicts:
#	pom.xml
2016-02-24 09:00:37 +01:00
Kai Zimmermann
7f2a9d1ed2 Features harmonised, more test descriptions 2016-02-23 09:57:18 +01:00
Kai Zimmermann
a9f91e90da Removed old issue numbers. Further documentation 2016-02-22 20:13:45 +01:00
Kai Zimmermann
13345406ee Upgraded 3rd party libs 2016-02-22 11:01:47 +01:00
Kai Zimmermann
b6509750bc Removed broken javadoc.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-18 10:22:21 +01:00
Kai Zimmermann
1c6223ba5d Improved readibility
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-18 10:12:36 +01:00
Kai Zimmermann
01b75fc932 Removed unnecessary entitygraph usage.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-17 09:57:07 +01:00
Kai Zimmermann
3334cf4a64 Updated test
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-17 08:36:36 +01:00
Kai Zimmermann
6a2b74e565 Enabled target.assignedDs load through action enitygraph.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-16 17:37:34 +01:00
Kai Zimmermann
38b750f674 DistributionSetAssignmentResult contains actions that do not reflect the
status on the DB. Needs to be avoided by returning actions IDs only and
force the user to query an updated action entity.

Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-02-16 17:37:06 +01:00
SirWayne
5d7ade1cf2 Add create tenant
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-15 16:20:45 +01:00
Michael Hirsch
2ef04bb437 Merge pull request #41 from bsinno/custom-target-filter-bug-fixes
👍 ok merging.
2016-02-15 13:13:30 +01:00
Michael Hirsch
7b79010fbf format sources with correct formatter.
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-15 12:32:12 +01:00
Michael Hirsch
21114a731d Merge pull request #42 from bsinno/EMPTY_CONTROLLER_ID
👍 is ok merging.
2016-02-15 12:11:41 +01:00
asharani-murugesh
a0a24376bb Revert to master copy
Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-15 10:43:07 +01:00
asharani-murugesh
158a9cfa20 RSQLUtility : convert query to lower case before parsing
Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-15 10:38:30 +01:00
Michael Hirsch
8e0c345bf2 Merge pull request #40 from bsinno/clean_code_add_description_to_junit_test
👍  is ok merging.
2016-02-15 08:57:25 +01:00
asharani-murugesh
59fb97fea2 In and Out parameter changes
Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-13 21:33:27 +01:00
asharani-murugesh
aac43d346f Bug fixes:
Custom filter detail view : Using =IN= parameter throws 'Unsupported
operator' exception and breaks the UI
Custom filter search : type any query.Search never gets finished.
Alloe case insensitive search for IN paramters

Signed-off-by: asharani-murugesh <asharani.murugesh@in.bosch.com>
2016-02-13 12:21:04 +01:00
Kai Zimmermann
c7254d665e Merge pull request #38 from bsinno/fix_wrong_count_select_statement_for_targetrolloutgroup
👍 ok
2016-02-12 15:57:48 +01:00
Jonathan Philip Knoblauch
88c854f2be Clean code for junit tests …
- Added messages to JUnit assertions
- Added Description when missing
- Changed to assertThat when assertEquals

Signed-off-by: Jonathan Philip Knoblauch <JonathanPhilip.Knoblauch@bosch-si.com>
2016-02-12 13:47:53 +01:00
Michael Hirsch
e2927acfca reduce logging from info to debug when checking rollout
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-12 13:18:55 +01:00
Michael Hirsch
b30375e9e6 fix count select statement join is wrong
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-12 12:36:12 +01:00
SirWayne
46a71c1b3a Use javax annotation for validation
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-10 16:51:45 +01:00
SirWayne
f78bd68c03 Verify that the target controller id cannot be empty
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-10 16:22:20 +01:00
SirWayne
b21f8f5c71 Clean Code Refactoring
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-09 13:36:58 +01:00
SirWayne
ceb23e65e4 Remove this for member variable
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-09 11:29:01 +01:00
SirWayne
1bb29338ac Clean Code Refactoring
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-09 10:16:07 +01:00
SirWayne
9ae2ef0bc0 Merge remote-tracking branch 'origin/code_style_sonar_rule_fixes' into Sonar_Fix_Rollout 2016-02-08 08:47:52 +01:00
SirWayne
4574c78908 Add SpecificationBuilder to avoid duplicate code
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-02-08 08:47:12 +01:00
Michael Hirsch
2a45fab9d7 make immediately return statement, not storing into local variable.
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-08 08:46:50 +01:00
Michael Hirsch
a488a42cc9 code sonar rule cleanup of DistributionSetManagament
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-05 16:01:25 +01:00
Michael Hirsch
7e92f5925e added flush before executing asynchronous group creation to avoid
InvalidDataAccessApiUsageException because Rollout entity has not yet ID
set.

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-02-05 08:12:12 +01:00