Commit Graph

594 Commits

Author SHA1 Message Date
Michael Hirsch
2ca807916c fix lookup by filename and not by ID because the ID is unique and the
filename exists multiple times

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-14 13:32:24 +02:00
Michael Hirsch
ad50f1abde Merge pull request #138 from bsinno/Bug/UI_NPE_Drag_And_Drop
Fix null handling for all drag and drop table
2016-04-14 10:22:35 +02:00
Michael Hirsch
e651be3a9b Merge pull request #134 from bsinno/Add_Missing_Event
Add missing TargetTagDeletedEvent
2016-04-14 10:22:25 +02:00
SirWayne
4b6a6a4a4a Refactoring: Extract some staff to private methods and remove duplicated
code

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-13 17:37:55 +02:00
Michael Hirsch
2a5b1c2fbb Merge pull request #141 from bsinno/Bug/Upload_Artifact
Bug/upload artifact
2016-04-13 16:52:40 +02:00
SirWayne
d21485cad4 Refactoring: Extract some staff to private methods
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-13 16:52:12 +02:00
SirWayne
46e71f622d Version should be set after id
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-13 15:47:08 +02:00
SirWayne
f70120d546 Set the id after the update
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-13 15:36:14 +02:00
SirWayne
b95b9c1ce6 Move @SuppressWarnings("unchecked") to the right line and remove unused
attributes

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-13 14:20:27 +02:00
Michael Hirsch
e9a8d95e6f Merge pull request #140 from bsinno/Bug/Upload_Artifact
Bug/upload artifact
2016-04-13 11:21:34 +02:00
Michael Hirsch
d052bef5d7 Merge pull request #139 from bsinno/fix_artifact_multiple_assignment_sha1_hash_lookup
fix the lookup of artifacts which exists multiple times with same lookup key e.g. SHA1
2016-04-13 11:20:24 +02:00
Michael Hirsch
d704ef99fd source code hygiene, better method naming and variable naming
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 16:22:43 +02:00
Michael Hirsch
d903be57b7 use correct mock parameters to ensure test
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 15:50:48 +02:00
Michael Hirsch
30e8230b8a correct usage of logging, missing parameters
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 15:48:19 +02:00
Michael Hirsch
cc8c674341 correct usage of logging, missing parameters
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 15:47:21 +02:00
Michael Hirsch
369d9da25a source code improvements
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 14:35:59 +02:00
SirWayne
27e4b550f2 Update the entity before call the super method
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-12 13:42:57 +02:00
SirWayne
d91922dc04 Update the entity before call the super method
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-12 13:37:07 +02:00
Michael Hirsch
b11a0bac5d reduce method cyclomatic complexity by extracting security check into
own method

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 12:18:59 +02:00
Michael Hirsch
0b5286299c fix unit tests after changing the lookup way
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 10:03:19 +02:00
Michael Hirsch
c4fd082098 fix the lookup of artifacts with the same lookup key, e.g. SHA1 hash if
multiple artifacts with key exists for different software modules

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
2016-04-12 09:39:07 +02:00
Michael Hirsch
85ec59b04e Merge pull request #124 from bsinno/Reduce_Duplicate_Code
Reduce duplicate code
2016-04-12 07:30:51 +02:00
SirWayne
319a226adc Fix null handling for all drag and drop table
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-11 15:05:02 +02:00
Michael Hirsch
80dde61085 Merge pull request #131 from bsinno/Move_anonymous_download_to_authentication_configuration_section
Move anonymous download to authentication configuration section
2016-04-09 09:07:07 +02:00
Jonathan Philip Knoblauch
40478dd675 Refactoring after review
- changed label sentence
- remove I18N to parent class
- remove empty lines
- set variable for configurationEnabledChange directly 

Signed-off-by: Jonathan Philip Knoblauch <JonathanPhilip.Knoblauch@bosch-si.com>
2016-04-08 17:15:15 +02:00
SirWayne
313751a3fd fix typo
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-08 16:05:38 +02:00
SirWayne
7731b549c3 Use for float uppercase F
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-08 16:03:29 +02:00
SirWayne
b26cde62df Use for float uppercase F
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-08 15:35:59 +02:00
SirWayne
3070dcfc3d Modify scope of protected attributes to private.
Create getter/setter to access the  the attribute.

see clean code Protected variables should be avoided because:
http://programmers.stackexchange.com/questions/162643/why-is-clean-code-suggesting-avoiding-protected-variables

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-08 15:01:26 +02:00
SirWayne
a021630c04 Remove empty lines
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-08 10:12:16 +02:00
Kai Zimmermann
1e28acb170 Update README.md 2016-04-08 08:16:47 +02:00
Jonathan Philip Knoblauch
d815aaf12c Added id to anonymous download checkbox
Signed-off-by: Jonathan Philip Knoblauch <JonathanPhilip.Knoblauch@bosch-si.com>
2016-04-07 15:58:25 +02:00
Jonathan Philip Knoblauch
7281c0e84e Added description for anonymous download checkbox
Signed-off-by: Jonathan Philip Knoblauch <JonathanPhilip.Knoblauch@bosch-si.com>
2016-04-07 15:25:31 +02:00
Jonathan Philip Knoblauch
9299161652 Added anonymous download section as part of authentication configuration section
Signed-off-by: Jonathan Philip Knoblauch <JonathanPhilip.Knoblauch@bosch-si.com>
2016-04-07 14:43:05 +02:00
SirWayne
4e2fd2befd Add missing TargetTagDeletedEvent
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 14:33:51 +02:00
SirWayne
08e0dc4b3d Add new abstract table to reduce the visible columns and add entity code
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 14:16:43 +02:00
SirWayne
762c313489 Remove full qualified pakcage
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 14:13:27 +02:00
SirWayne
5e0f07b852 Add new abstract table to reduce the visible columns and add entity code
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 14:12:26 +02:00
SirWayne
27118e2939 fix typo
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 13:23:08 +02:00
SirWayne
15702cb5c9 Improve javadoc
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 13:11:16 +02:00
SirWayne
c069b904b2 Use Optional.ofNullable instead of a if statement
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 13:00:39 +02:00
SirWayne
fdee152885 Fix typo
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 12:42:50 +02:00
SirWayne
6f2383b077 Add Javadoc
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 12:23:56 +02:00
SirWayne
6e7d56d71d Merge branch 'master' into Reduce_Duplicate_Code
Conflicts:
	hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/HawkbitCommonUtil.java


Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 12:06:11 +02:00
SirWayne
927ef461b9 Update Distribution Set in table
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 12:01:08 +02:00
SirWayne
e09ff4a716 Refactor TableHeader
Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-07 10:32:59 +02:00
Michael Hirsch
cadf67ad6c Merge pull request #122 from bsinno/reduce-duplicate-metadata
Reduce duplicate metadata code
2016-04-07 08:34:49 +02:00
SirWayne
dc18bfea7b Refactoring Table, TableHeader and Detail Layout components
- Add interfaces to reduce boiler plate code
 - Add generic to reuse code
 - Try to remove duplicate code

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
2016-04-06 17:42:02 +02:00
Michael Hirsch
747df51f1a Merge pull request #118 from bsinno/Methods_only_called_by_inner_classes_should_move_to_those_classes
Methods only called by inner classes should move to those classes
2016-04-06 13:59:38 +02:00
Kai Zimmermann
f4f9c10186 Optimized equals.
Signed-off-by: Kai Zimmermann <kai.zimmermann@bosch-si.com>
2016-04-06 10:57:23 +02:00