lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Simple UI: Streaming upload (#2254)

Browse Source 
thus not loading whole artifact into memory

Signed-off-by: Avgustin Marinov <Avgustin.Marinov@bosch.com>
This commit is contained in:
Avgustin Marinov
2025-01-29 13:44:31 +02:00
committed by GitHub
parent 7861cfcac7
commit b108762d54
7 changed files with 188 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

161
hawkbit-sdk/hawkbit-sdk-commons/src/main/java/org/eclipse/hawkbit/sdk/HawkbitClient.java
View File

@@ -9,21 +9,44 @@
*/
package org.eclipse.hawkbit.sdk;
import java.io.BufferedOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.lang.annotation.Annotation;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Proxy;
import java.net.HttpURLConnection;
import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.util.Base64;
import java.util.List;
import java.util.Objects;
import java.util.UUID;
import java.util.function.BiFunction;
import java.util.stream.Stream;
import com.fasterxml.jackson.databind.ObjectMapper;
import feign.Client;
import feign.Contract;
import feign.Feign;
import feign.RequestInterceptor;
import feign.RequestTemplate;
import feign.codec.Decoder;
import feign.codec.Encoder;
import feign.codec.ErrorDecoder;
import lombok.Builder;
import lombok.extern.slf4j.Slf4j;
import org.springframework.http.HttpStatusCode;
import org.springframework.http.ResponseEntity;
import org.springframework.util.ObjectUtils;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RequestPart;
import org.springframework.web.multipart.MultipartFile;
@Slf4j
@Builder
@@ -104,15 +127,145 @@ public class HawkbitClient {
}
private <T> T service(final Class<T> serviceType, final Tenant tenant, final Controller controller) {
final T service = service0(serviceType, tenant, controller);
if (serviceType.isInterface() // proxy only interfaces
&& Stream.of(serviceType.getDeclaredMethods()) // and has MultipartFile argument
.anyMatch(method -> method.getAnnotation(PostMapping.class) != null
&& List.of(method.getParameterTypes()).contains(MultipartFile.class))) {
// doesn't use feign client since it doesn't (?) support streaming - loading all in memory which could lead to OOM
// https://github.com/OpenFeign/feign-form/issues/121 (?)
return proxy(serviceType, service, tenant, controller);
} else { // default
return service;
}
}
@SuppressWarnings("unchecked")
private <T> T proxy(final Class<T> serviceType, final T service, final Tenant tenant, final Controller controller) {
final ObjectMapper objectMapper = new ObjectMapper();
return (T) Proxy.newProxyInstance(service.getClass().getClassLoader(), new Class<?>[] { serviceType }, (proxy, method, args) -> {
try {
final Class<?>[] parameterTypes = method.getParameterTypes();
if (method.getDeclaringClass() == serviceType && List.of(parameterTypes).contains(MultipartFile.class)) {
return processMultipartFormData(method, args, tenant, controller, parameterTypes, objectMapper);
} else {
return method.invoke(service, args);
}
} catch (final InvocationTargetException e) {
throw e.getTargetException() == null ? e : e.getTargetException();
}
});
}
private static final String CRLF = "\r\n";
private Object processMultipartFormData(
final Method method, final Object[] args,
final Tenant tenant, final Controller controller,
final Class<?>[] parameterTypes, final ObjectMapper objectMapper) throws IOException {
final PostMapping postMapping = method.getAnnotation(PostMapping.class);
final Annotation[][] parametersAnnotations = method.getParameterAnnotations();
// build path - replace @PathVariables
String path = postMapping.value()[0];
for (int i = 0; i < args.length; i++) {
final PathVariable pathVariable = getAnnotation(PathVariable.class, parametersAnnotations[i]);
if (pathVariable != null) {
path = path.replace("{" + pathVariable.value() + "}", args[i].toString());
}
}
final HttpURLConnection conn = (HttpURLConnection) new URL(
(controller == null ? hawkBitServer.getMgmtUrl() : hawkBitServer.getDdiUrl()) + path).openConnection();
conn.setRequestMethod("POST");
// deal with authentication - only from headers1
final RequestTemplate requestTemplate = new RequestTemplate();
requestInterceptorFn.apply(tenant, controller).apply(requestTemplate);
requestTemplate.headers().forEach((k, v) -> v.forEach(e -> conn.setRequestProperty(k, e)));
final String boundary = UUID.randomUUID().toString().replace("-", "");
conn.setRequestProperty("content-type", "multipart/form-data;boundary=" + boundary);
// consumes what the method produces
final String[] consumes = postMapping.produces();
if (!ObjectUtils.isEmpty(consumes)) {
conn.setRequestProperty("accept", String.join(",", consumes));
}
conn.setDoOutput(true);
conn.setDoInput(true);
try (final OutputStream out = new BufferedOutputStream(conn.getOutputStream())) {
for (int i = 0; i < args.length; i++) {
final Class<?> type = parameterTypes[i];
if (MultipartFile.class.isAssignableFrom(type)) {
final MultipartFile multipartFile = (MultipartFile) args[i];
if (multipartFile != null) {
writeMultipartFile(multipartFile, out, boundary, parametersAnnotations[i]);
}
} else {
writeSimpleFormData(args[i], out, boundary, parametersAnnotations[i]);
}
}
out.write(("--" + boundary + "--\r\n").getBytes(StandardCharsets.UTF_8));
}
return method.getReturnType() == ResponseEntity.class
? new ResponseEntity<Object>(
objectMapper.readValue(
conn.getInputStream(),
(Class<?>) ((ParameterizedType) method.getGenericReturnType()).getActualTypeArguments()[0]),
HttpStatusCode.valueOf(conn.getResponseCode()))
: objectMapper.readValue(conn.getInputStream(), method.getReturnType());
}
private void writeMultipartFile(
final MultipartFile multipartFile, final OutputStream out, final String boundary, final Annotation[] parametersAnnotations)
throws IOException {
final String name = Objects.requireNonNull(
getAnnotation(RequestPart.class, parametersAnnotations), "MultipartFile shall have RequestPart annotation")
.value();
try (final InputStream in = multipartFile.getInputStream()) {
out.write(("--" + boundary + CRLF +
"Content-Disposition: form-data; name=\"" + name + "\"; filename=\"" + multipartFile.getName() + "\"\r\n" +
"Content-Type: " + multipartFile.getContentType() + "\r\n\r\n"
).getBytes(StandardCharsets.UTF_8));
final byte[] buff = new byte[8096];
for (int read; (read = in.read(buff)) != -1; ) {
out.write(buff, 0, read);
}
out.write(CRLF.getBytes(StandardCharsets.UTF_8));
}
}
private void writeSimpleFormData(
final Object arg, final OutputStream out, final String boundary, final Annotation[] parameterAnnotations) throws IOException {
if (arg != null) {
final RequestParam requestParam = getAnnotation(RequestParam.class, parameterAnnotations);
if (requestParam != null) {
out.write(("--" + boundary + CRLF +
"Content-Disposition: form-data; name=\"" + requestParam.value() + "\"\r\n\r\n" +
arg + CRLF
).getBytes(StandardCharsets.UTF_8));
}
} // otherwise default
}
@SuppressWarnings("unchecked")
private <T extends Annotation> T getAnnotation(final Class<T> annotationClass, final Annotation[] annotations) {
for (final Annotation annotation : annotations) {
if (annotation.annotationType().equals(annotationClass)) {
return (T) annotation;
}
}
return null;
}
private <T> T service0(final Class<T> serviceType, final Tenant tenant, final Controller controller) {
return Feign.builder().client(client)
.encoder(encoder)
.decoder(decoder)
.errorDecoder(errorDecoder)
.contract(contract)
.requestInterceptor(requestInterceptorFn.apply(tenant, controller))
.target(serviceType,
controller == null ?
hawkBitServer.getMgmtUrl() :
hawkBitServer.getDdiUrl());
.target(serviceType, controller == null ? hawkBitServer.getMgmtUrl() : hawkBitServer.getDdiUrl());
}
}