diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataAddUpdateWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataAddUpdateWindowLayout.java index b80748c27..dc7e2f0b9 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataAddUpdateWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataAddUpdateWindowLayout.java @@ -8,11 +8,13 @@ */ package org.eclipse.hawkbit.ui.artifacts.smtable; +import java.util.function.BooleanSupplier; + import org.eclipse.hawkbit.ui.common.detailslayout.MetaDataAddUpdateWindowLayout; import org.eclipse.hawkbit.ui.utils.VaadinMessageSource; import com.vaadin.ui.CheckBox; -import com.vaadin.ui.ComponentContainer; +import com.vaadin.ui.VerticalLayout; /** * Class for sm metadata add/update window layout. @@ -24,23 +26,28 @@ public class SmMetaDataAddUpdateWindowLayout extends MetaDataAddUpdateWindowLayo * Constructor for AbstractTagWindowLayout * * @param i18n - * I18N + * VaadinMessageSource + * @param hasMetadataChangePermission + * checks the permission allowing to change metadata entities */ - public SmMetaDataAddUpdateWindowLayout(final VaadinMessageSource i18n) { - super(i18n); + public SmMetaDataAddUpdateWindowLayout(final VaadinMessageSource i18n, + final BooleanSupplier hasMetadataChangePermission) { + super(i18n, hasMetadataChangePermission); this.isVisibleForTarget = metaDataComponentBuilder.createVisibleForTargetsField(binder); } - /** - * @return form layout checkbox container for software module - */ @Override - public ComponentContainer getRootComponent() { - final ComponentContainer formLayout = super.getRootComponent(); + protected VerticalLayout getMetadataAddUpdateLayout() { + final VerticalLayout addUpdateLayout = super.getMetadataAddUpdateLayout(); + addUpdateLayout.addComponent(isVisibleForTarget); - formLayout.addComponent(isVisibleForTarget); + return addUpdateLayout; + } - return formLayout; + @Override + protected void disableMetadataInputComponents() { + super.disableMetadataInputComponents(); + isVisibleForTarget.setEnabled(false); } } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataWindowLayout.java index 2c6d9a8ca..e27939a84 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SmMetaDataWindowLayout.java @@ -67,9 +67,10 @@ public class SmMetaDataWindowLayout extends AbstractMetaDataWindowLayout { this.entityFactory = entityFactory; this.smMetaDataWindowGrid = new MetaDataWindowGrid<>(i18n, eventBus, permChecker, uiNotification, - new SmMetaDataDataProvider(smManagement), this::deleteMetaData); + new SmMetaDataDataProvider(smManagement), this::hasMetadataChangePermission, this::deleteMetaData); - this.smMetaDataAddUpdateWindowLayout = new SmMetaDataAddUpdateWindowLayout(i18n); + this.smMetaDataAddUpdateWindowLayout = new SmMetaDataAddUpdateWindowLayout(i18n, + this::hasMetadataChangePermission); this.addSmMetaDataWindowController = new AddMetaDataWindowController(i18n, uiNotification, smMetaDataAddUpdateWindowLayout, this::createMetaData, this::isDuplicate); this.updateSmMetaDataWindowController = new UpdateMetaDataWindowController(i18n, uiNotification, diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/AbstractMetaDataWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/AbstractMetaDataWindowLayout.java index 208c4fd49..fe4d851bf 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/AbstractMetaDataWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/AbstractMetaDataWindowLayout.java @@ -38,6 +38,7 @@ public abstract class AbstractMetaDataWindowLayout extends HorizontalLayout { protected final VaadinMessageSource i18n; protected final transient UIEventBus eventBus; protected final UINotification uiNotification; + protected final SpPermissionChecker permChecker; private final MetadataWindowGridHeader metadataWindowGridHeader; @@ -62,9 +63,23 @@ public abstract class AbstractMetaDataWindowLayout extends HorizontalLayout { this.i18n = i18n; this.eventBus = eventBus; this.uiNotification = uiNotification; + this.permChecker = permChecker; this.metadataWindowGridHeader = new MetadataWindowGridHeader(i18n, permChecker, eventBus, - this::showAddMetaDataLayout); + this::hasMetadataChangePermission, this::showAddMetaDataLayout); + } + + // can be overriden in child classes for entity-specific permission + protected boolean hasMetadataChangePermission() { + return permChecker.hasUpdateRepositoryPermission(); + } + + private void showAddMetaDataLayout() { + getMetaDataWindowGrid().deselectAll(); + getAddMetaDataWindowController().populateWithData(null); + saveCallback.accept(getAddMetaDataWindowController().getSaveDialogCloseListener()); + + resetSaveButton(); } protected MetaData createMetaData(final ProxyMetaData entity) { @@ -129,14 +144,6 @@ public abstract class AbstractMetaDataWindowLayout extends HorizontalLayout { protected abstract void doDeleteMetaDataByKey(final String metaDataKey); - private void showAddMetaDataLayout() { - getMetaDataWindowGrid().deselectAll(); - getAddMetaDataWindowController().populateWithData(null); - saveCallback.accept(getAddMetaDataWindowController().getSaveDialogCloseListener()); - - resetSaveButton(); - } - /** * @return add meta data window controller */ diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/DistributionSetDetailsHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/DistributionSetDetailsHeader.java index 15c4c8d7e..69ab1ad50 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/DistributionSetDetailsHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/DistributionSetDetailsHeader.java @@ -34,17 +34,17 @@ public class DistributionSetDetailsHeader extends AbstractDetailsHeader { + private final BooleanSupplier hasMetadataChangePermission; protected final MetaDataAddUpdateWindowLayoutComponentBuilder metaDataComponentBuilder; private final TextField metadataKey; @@ -30,11 +33,15 @@ public class MetaDataAddUpdateWindowLayout extends AbstractEntityWindowLayout extends AbstractGrid implem public static final String META_DATA_VALUE_ID = "metaDataValue"; public static final String META_DATA_DELETE_BUTTON_ID = "metaDataDeleteButton"; + private final transient BooleanSupplier hasMetadataChangePermission; private final transient DeleteSupport metaDataDeleteSupport; /** @@ -52,17 +54,20 @@ public class MetaDataWindowGrid extends AbstractGrid implem * @param notification * UINotification * @param dataProvider - * AbstractMetaDataDataProvider for filter support + * provides entity-specific metadata entities + * @param hasMetadataChangePermission + * checks the permission allowing to change metadata entities * @param itemsDeletionCallback - * Grid item deletion Call back for event listener + * callback method to delete metadata entities * */ public MetaDataWindowGrid(final VaadinMessageSource i18n, final UIEventBus eventBus, final SpPermissionChecker permissionChecker, final UINotification notification, - final AbstractMetaDataDataProvider dataProvider, + final AbstractMetaDataDataProvider dataProvider, final BooleanSupplier hasMetadataChangePermission, final Predicate> itemsDeletionCallback) { super(i18n, eventBus, permissionChecker); + this.hasMetadataChangePermission = hasMetadataChangePermission; this.metaDataDeleteSupport = new DeleteSupport<>(this, i18n, notification, "caption.metadata", "caption.metadata.plur", ProxyMetaData::getKey, itemsDeletionCallback, UIComponentIdProvider.METADATA_DELETE_CONFIRMATION_DIALOG); @@ -79,7 +84,7 @@ public class MetaDataWindowGrid extends AbstractGrid implem @Override public String getGridId() { - return UIComponentIdProvider.METDATA_WINDOW_TABLE_ID; + return UIComponentIdProvider.METADATA_WINDOW_TABLE_ID; } @Override @@ -91,7 +96,7 @@ public class MetaDataWindowGrid extends AbstractGrid implem .setCaption(i18n.getMessage("header.value")).setHidden(true).setHidable(true); GridComponentBuilder.addDeleteColumn(this, i18n, META_DATA_DELETE_BUTTON_ID, metaDataDeleteSupport, - UIComponentIdProvider.META_DATA_DELET_ICON, e -> permissionChecker.hasDeleteRepositoryPermission()); + UIComponentIdProvider.META_DATA_DELET_ICON, e -> hasMetadataChangePermission.getAsBoolean()); } @Override diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataDetailsGrid.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataDetailsGrid.java index ddf1b4aa3..41eaa7385 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataDetailsGrid.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataDetailsGrid.java @@ -83,7 +83,7 @@ public class MetadataDetailsGrid extends AbstractGrid imple @Override public String getGridId() { - return typePrefix + "." + UIComponentIdProvider.METDATA_DETAILS_TABLE_ID; + return typePrefix + "." + UIComponentIdProvider.METADATA_DETAILS_TABLE_ID; } @Override diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataWindowGridHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataWindowGridHeader.java index 761693acf..526a69724 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataWindowGridHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/MetadataWindowGridHeader.java @@ -8,6 +8,8 @@ */ package org.eclipse.hawkbit.ui.common.detailslayout; +import java.util.function.BooleanSupplier; + import org.eclipse.hawkbit.ui.SpPermissionChecker; import org.eclipse.hawkbit.ui.common.grid.header.AbstractGridHeader; import org.eclipse.hawkbit.ui.common.grid.header.support.AddHeaderSupport; @@ -35,15 +37,18 @@ public class MetadataWindowGridHeader extends AbstractGridHeader { * SpPermissionChecker * @param eventBus * UIEventBus + * @param hasMetadataChangePermission + * checks the permission allowing to change metadata entities * @param addNewItemCallback - * Runnable + * callback method to add new metadata entities */ public MetadataWindowGridHeader(final VaadinMessageSource i18n, final SpPermissionChecker permChecker, - final UIEventBus eventBus, final Runnable addNewItemCallback) { + final UIEventBus eventBus, final BooleanSupplier hasMetadataChangePermission, + final Runnable addNewItemCallback) { super(i18n, permChecker, eventBus); - if (permChecker.hasCreateRepositoryPermission()) { - this.addHeaderSupport = new AddHeaderSupport(i18n, UIComponentIdProvider.METADTA_ADD_ICON_ID, + if (hasMetadataChangePermission.getAsBoolean()) { + this.addHeaderSupport = new AddHeaderSupport(i18n, UIComponentIdProvider.METADATA_ADD_ICON_ID, addNewItemCallback, () -> false); } else { this.addHeaderSupport = null; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsHeader.java index 0e813ae2c..ea19ff039 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsHeader.java @@ -95,11 +95,6 @@ public class SoftwareModuleDetailsHeader extends AbstractDetailsHeader - * Generic type + * Generic type */ public abstract class AbstractDetailsHeader extends AbstractMasterAwareGridHeader { private static final long serialVersionUID = 1L; @@ -37,13 +37,13 @@ public abstract class AbstractDetailsHeader extends AbstractMasterAwareGridHe * Constructor for AbstractDetailsHeader * * @param i18n - * VaadinMessageSource + * VaadinMessageSource * @param permChecker - * SpPermissionChecker + * SpPermissionChecker * @param eventBus - * UIEventBus + * UIEventBus * @param uiNotification - * UINotification + * UINotification */ public AbstractDetailsHeader(final VaadinMessageSource i18n, final SpPermissionChecker permChecker, final UIEventBus eventBus, final UINotification uiNotification) { @@ -53,17 +53,29 @@ public abstract class AbstractDetailsHeader extends AbstractMasterAwareGridHe if (hasEditPermission()) { this.editDetailsHeaderSupport = new EditDetailsHeaderSupport(i18n, getEditIconId(), this::onEdit); + } else { + this.editDetailsHeaderSupport = null; + } + + if (hasMetadataReadPermission()) { this.metaDataDetailsHeaderSupport = new MetaDataDetailsHeaderSupport(i18n, getMetaDataIconId(), this::showMetaData); } else { - this.editDetailsHeaderSupport = null; this.metaDataDetailsHeaderSupport = null; } addHeaderSupports(Arrays.asList(editDetailsHeaderSupport, metaDataDetailsHeaderSupport)); } - protected abstract boolean hasEditPermission(); + // can be overriden in child classes for entity-specific permission + protected boolean hasEditPermission() { + return permChecker.hasUpdateRepositoryPermission(); + } + + // can be overriden in child classes for entity-specific permission + protected boolean hasMetadataReadPermission() { + return permChecker.hasReadRepositoryPermission(); + } protected abstract String getEditIconId(); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/header/support/AddHeaderSupport.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/header/support/AddHeaderSupport.java index 32ea1ff7b..390062f7a 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/header/support/AddHeaderSupport.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/header/support/AddHeaderSupport.java @@ -35,13 +35,13 @@ public class AddHeaderSupport implements HeaderSupport { * Constructor for AddHeaderSupport * * @param i18n - * AddHeaderSupport + * VaadinMessageSource * @param addIconId - * Add icon id + * Add icon id * @param addItemCallback - * Runnable + * callback method to add new entities * @param maximizedStateSupplier - * BooleanSupplier + * provides the max/min state of the grid */ public AddHeaderSupport(final VaadinMessageSource i18n, final String addIconId, final Runnable addItemCallback, final BooleanSupplier maximizedStateSupplier) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DsMetaDataWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DsMetaDataWindowLayout.java index a040e5bf3..3fb2868b3 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DsMetaDataWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DsMetaDataWindowLayout.java @@ -69,9 +69,9 @@ public class DsMetaDataWindowLayout extends AbstractMetaDataWindowLayout { this.entityFactory = entityFactory; this.dsMetaDataWindowGrid = new MetaDataWindowGrid<>(i18n, eventBus, permChecker, uiNotification, - new DsMetaDataDataProvider(dsManagement), this::deleteMetaData); + new DsMetaDataDataProvider(dsManagement), this::hasMetadataChangePermission, this::deleteMetaData); - this.metaDataAddUpdateWindowLayout = new MetaDataAddUpdateWindowLayout(i18n); + this.metaDataAddUpdateWindowLayout = new MetaDataAddUpdateWindowLayout(i18n, this::hasMetadataChangePermission); this.addDsMetaDataWindowController = new AddMetaDataWindowController(i18n, uiNotification, metaDataAddUpdateWindowLayout, this::createMetaData, this::isDuplicate); this.updateDsMetaDataWindowController = new UpdateMetaDataWindowController(i18n, uiNotification, diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetDetails.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetDetails.java index c7ff9e213..142147fbf 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetDetails.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetDetails.java @@ -87,7 +87,7 @@ public class TargetDetails extends AbstractGridDetailsLayout { new SimpleEntry<>(i18n.getMessage("caption.tags.tab"), getTargetTagToken().getTagPanel()), new SimpleEntry<>(i18n.getMessage("caption.logs.tab"), logDetails))); - if (permissionChecker.hasCreateRepositoryPermission()) { + if (permissionChecker.hasReadRepositoryPermission()) { this.targetMetadataGrid = new MetadataDetailsGrid<>(i18n, eventBus, UIComponentIdProvider.TARGET_TYPE_PREFIX, this::showMetadataDetails, new TargetMetaDataDataProvider(targetManagement)); diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetMetaDataWindowLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetMetaDataWindowLayout.java index 20382efa8..012a7200c 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetMetaDataWindowLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetMetaDataWindowLayout.java @@ -70,9 +70,10 @@ public class TargetMetaDataWindowLayout extends AbstractMetaDataWindowLayout(i18n, eventBus, permChecker, uiNotification, - new TargetMetaDataDataProvider(targetManagement), this::deleteMetaData); + new TargetMetaDataDataProvider(targetManagement), this::hasMetadataChangePermission, + this::deleteMetaData); - this.metaDataAddUpdateWindowLayout = new MetaDataAddUpdateWindowLayout(i18n); + this.metaDataAddUpdateWindowLayout = new MetaDataAddUpdateWindowLayout(i18n, this::hasMetadataChangePermission); this.addTargetMetaDataWindowController = new AddMetaDataWindowController(i18n, uiNotification, metaDataAddUpdateWindowLayout, this::createMetaData, this::isDuplicate); this.updateTargetMetaDataWindowController = new UpdateMetaDataWindowController(i18n, uiNotification, diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/UIComponentIdProvider.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/UIComponentIdProvider.java index e4e3c1701..f473c9dec 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/UIComponentIdProvider.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/utils/UIComponentIdProvider.java @@ -1244,15 +1244,15 @@ public final class UIComponentIdProvider { /** * Metadata add icon id. */ - public static final String METADTA_ADD_ICON_ID = "metadata.add.icon.id"; + public static final String METADATA_ADD_ICON_ID = "metadata.add.icon.id"; /** * Metadata details table id. */ - public static final String METDATA_DETAILS_TABLE_ID = "metadata.details.table.id"; + public static final String METADATA_DETAILS_TABLE_ID = "metadata.details.table.id"; /** * Metadata window table id. */ - public static final String METDATA_WINDOW_TABLE_ID = "metadata.window.table.id"; + public static final String METADATA_WINDOW_TABLE_ID = "metadata.window.table.id"; /** * Distribution set table - Manage metadata id.