From aaac0455018e776faca271a981269e1ed555b0fa Mon Sep 17 00:00:00 2001 From: kaizimmerm Date: Tue, 29 Nov 2016 12:10:10 +0100 Subject: [PATCH] Fixed final sonar issues. Signed-off-by: kaizimmerm --- .../ui/artifacts/smtable/SoftwareModuleTableHeader.java | 3 +-- .../ui/artifacts/smtable/SoftwareModuleTableLayout.java | 2 +- .../java/org/eclipse/hawkbit/ui/login/HawkbitLoginUI.java | 2 +- .../src/main/java/org/eclipse/hawkbit/ui/login/LoginView.java | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableHeader.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableHeader.java index c1deddfbf..66392840e 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableHeader.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableHeader.java @@ -8,7 +8,6 @@ */ package org.eclipse.hawkbit.ui.artifacts.smtable; -import org.eclipse.hawkbit.repository.EntityFactory; import org.eclipse.hawkbit.repository.SpPermissionChecker; import org.eclipse.hawkbit.ui.artifacts.event.SMFilterEvent; import org.eclipse.hawkbit.ui.artifacts.event.SoftwareModuleEvent; @@ -37,7 +36,7 @@ public class SoftwareModuleTableHeader extends AbstractTableHeader { private final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow; SoftwareModuleTableHeader(final I18N i18n, final SpPermissionChecker permChecker, final UIEventBus eventbus, - final ArtifactUploadState artifactUploadState, final EntityFactory entityFactory, + final ArtifactUploadState artifactUploadState, final SoftwareModuleAddUpdateWindow softwareModuleAddUpdateWindow) { super(i18n, permChecker, eventbus, null, null, artifactUploadState); this.softwareModuleAddUpdateWindow = softwareModuleAddUpdateWindow; diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableLayout.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableLayout.java index 36b5600ee..82804cc82 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableLayout.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/smtable/SoftwareModuleTableLayout.java @@ -38,7 +38,7 @@ public class SoftwareModuleTableLayout extends AbstractTableLayout { softwareManagement, entityFactory, permChecker); super.init( - new SoftwareModuleTableHeader(i18n, permChecker, eventBus, artifactUploadState, entityFactory, + new SoftwareModuleTableHeader(i18n, permChecker, eventBus, artifactUploadState, softwareModuleAddUpdateWindow), new SoftwareModuleTable(eventBus, i18n, uiNotification, artifactUploadState, softwareManagement, uploadViewAcceptCriteria, swMetadataPopupLayout), diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/HawkbitLoginUI.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/HawkbitLoginUI.java index e3d458999..d283d63e7 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/HawkbitLoginUI.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/HawkbitLoginUI.java @@ -42,7 +42,7 @@ public class HawkbitLoginUI extends DefaultHawkbitUI { private final SpringViewProvider viewProvider; - private final ApplicationContext context; + private final transient ApplicationContext context; @Autowired protected HawkbitLoginUI(final SpringViewProvider viewProvider, final ApplicationContext context) { diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/LoginView.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/LoginView.java index 345c8f7e8..07c0c923c 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/LoginView.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/login/LoginView.java @@ -69,13 +69,13 @@ public class LoginView extends VerticalLayout implements View { private static final String SP_LOGIN_USER = "sp-login-user"; private static final String SP_LOGIN_TENANT = "sp-login-tenant"; - private final VaadinSecurity vaadinSecurity; + private final transient VaadinSecurity vaadinSecurity; private final I18N i18n; private final UiProperties uiProperties; - private final MultitenancyIndicator multiTenancyIndicator; + private final transient MultitenancyIndicator multiTenancyIndicator; private final transient AntPathMatcher matcher = new AntPathMatcher(); private boolean useCookie = true;