Removed old issue numbers. Further documentation

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/DeploymentManagement.java

@@ -365,7 +365,7 @@ public class DeploymentManagement {
         }).collect(Collectors.toList())).stream()
                 .collect(Collectors.toMap(a -> a.getTarget().getControllerId(), Function.identity()));
 
-        // MECS-720 create initial action status when action is created so we
+        // create initial action status when action is created so we
         // remember the initial
         // running status because we will change the status of the action itself
         // and with this action

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/DistributionSetManagement.java

@@ -294,8 +294,7 @@ public class DistributionSetManagement {
         // hard delete the rest if exixts
         if (!toHardDelete.isEmpty()) {
             // don't give the delete statement an empty list, JPA/Oracle cannot
-            // handle the empty list,
-            // see MECS-403
+            // handle the empty list
             distributionSetRepository.deleteByIdIn(toHardDelete);
         }
     }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/SystemManagement.java

@@ -280,7 +280,7 @@ public class SystemManagement implements EnvironmentAware {
      * @return {@code true} in case the tenant exits or {@code false} if not
      */
     @Cacheable(value = "currentTenant", keyGenerator = "currentTenantKeyGenerator")
-    // MECS-903 set transaction to not supported, due we call this in
+    // set transaction to not supported, due we call this in
     // BaseEntity#prePersist methods
     // and it seems that JPA committing the transaction when executing this
     // transactional method,

hawkbit-repository/src/test/java/org/eclipse/hawkbit/repository/ActionTest.java

@@ -14,10 +14,16 @@ import org.eclipse.hawkbit.repository.model.Action;
 import org.eclipse.hawkbit.repository.model.Action.ActionType;
 import org.junit.Test;
 
+import ru.yandex.qatools.allure.annotations.Description;
+import ru.yandex.qatools.allure.annotations.Features;
+import ru.yandex.qatools.allure.annotations.Stories;
+
+@Features("Unit Tests - Repository")
+@Stories("Deployment Management")
 public class ActionTest {
 
-    // issue MECS-670 timeforced update and eTAG calculation
     @Test
+    @Description("Ensures that timeforced moded switch from soft to forces after defined timeframe.")
     public void timeforcedHitNewHasCodeIsGenerated() throws InterruptedException {
 
         final boolean active = true;

hawkbit-repository/src/test/java/org/eclipse/hawkbit/repository/ArtifactManagementNoMongoDbTest.java

@@ -25,9 +25,6 @@ import ru.yandex.qatools.allure.annotations.Stories;
 /**
  * Addition tests next to {@link ArtifactManagementTest} with no running MongoDB
  *
- *
- *
- *
  */
 @Features("Component Tests - Repository")
 @Stories("Artifact Management")

hawkbit-repository/src/test/java/org/eclipse/hawkbit/repository/DeploymentManagementTest.java

@@ -140,7 +140,6 @@ public class DeploymentManagementTest extends AbstractIntegrationTest {
 
     @Test
     @Description("Test verifies that an assignment with automatic cancelation works correctly even if the update is split into multiple partitions on the database.")
-    @Issue("MECS-674")
     public void multiAssigmentHistoryOverMultiplePagesResultsInTwoActiveAction() {
 
         final DistributionSet cancelDs = TestDataUtil.generateDistributionSet("Canceled DS", "1.0", softwareManagement,

hawkbit-rest-resource/src/main/java/org/eclipse/hawkbit/controller/RootController.java

@@ -435,8 +435,6 @@ public class RootController implements EnvironmentAware {
         LOG.debug("Controller reported intermediate status (actionid: {}, targetid: {}) as we got {} report.", actionid,
                 targetid, feedback.getStatus().getExecution());
         actionStatus.setStatus(Status.RUNNING);
-        // MECS-400: we should not use the unstructed message list for
-        // the server comment on the status.
         actionStatus.addMessage("Controller reported: " + feedback.getStatus().getExecution());
     }
 

hawkbit-rest-resource/src/test/java/org/eclipse/hawkbit/rest/resource/DistributionSetTypeResourceTest.java

@@ -46,9 +46,6 @@ import ru.yandex.qatools.allure.annotations.Stories;
 /**
  * Test for {@link DistributionSetTypeResource}.
  *
- *
- *
- *
  */
 @Features("Component Tests - Management API")
 @Stories("Distribution Set Type Resource")

hawkbit-rest-resource/src/test/java/org/eclipse/hawkbit/rest/resource/DownloadResourceTest.java

@@ -30,10 +30,6 @@ import org.springframework.context.annotation.Description;
 import ru.yandex.qatools.allure.annotations.Features;
 import ru.yandex.qatools.allure.annotations.Stories;
 
-/**
- *
- *
- */
 @Features("Component Tests - Management API")
 @Stories("Download Resource")
 public class DownloadResourceTest extends AbstractIntegrationTestWithMongoDB {

hawkbit-rest-resource/src/test/java/org/eclipse/hawkbit/rest/resource/RolloutResourceTest.java

@@ -99,7 +99,7 @@ public class RolloutResourceTest extends AbstractIntegrationTest {
                 .andReturn();
     }
 
-    @Description("TODO")
+    @Description("Ensures that the repository refuses to create rollout without a defined target filter set.")
     public void missingTargetFilterQueryInRollout() throws Exception {
 
         final String targetFilterQuery = null;

hawkbit-rest-resource/src/test/java/org/eclipse/hawkbit/rest/resource/SoftwareModuleResourceTest.java

@@ -112,14 +112,6 @@ public class SoftwareModuleResourceTest extends AbstractIntegrationTestWithMongo
 
     }
 
-    /**
-     * Test method for
-     * {@link org.eclipse.hawkbit.rest.resource.SoftwareModuleResource#uploadArtifact(java.lang.Long, org.springframework.web.multipart.MultipartFile)}
-     * .
-     *
-     * @throws Exception
-     *             if test fails
-     */
     @Test
     @Description("Tests the uppload of an artifact binary. The upload is executed and the content checked in the repository for completenes.")
     public void uploadArtifact() throws Exception {

hawkbit-rest-resource/src/test/java/org/eclipse/hawkbit/rest/resource/TargetResourceTest.java

@@ -74,8 +74,6 @@ import ru.yandex.qatools.allure.annotations.Stories;
  */
 @Features("Component Tests - Management API")
 @Stories("Target Resource")
-// TODO: fully document tests -> @Description for long text and reasonable
-// method name as short text
 public class TargetResourceTest extends AbstractIntegrationTest {
 
     private static final String TARGET_DESCRIPTION_TEST = "created in test";
@@ -103,10 +101,8 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     private static final String JSON_PATH_CONTROLLERID = JSON_PATH_ROOT + JSON_PATH_FIELD_CONTROLLERID;
     private static final String JSON_PATH_DESCRIPTION = JSON_PATH_ROOT + JSON_PATH_FIELD_DESCRIPTION;
 
-    // TODO kzimmerm: test *modified after entity change
-
     @Test
-    // MECS-1064
+    @Description("Ensures that actions list is in exptected order.")
     public void getActionStatusReturnsCorrectType() throws Exception {
         final int limitSize = 2;
         final String knownTargetId = "targetId";
@@ -141,6 +137,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that security token is not returned if user does not have READ_TARGET_SEC_TOKEN permission.")
     @WithUser(allSpPermissions = false, authorities = { SpPermission.READ_TARGET, SpPermission.CREATE_TARGET })
     public void securityTokenIsNotInResponseIfMissingPermission() throws Exception {
 
@@ -152,6 +149,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that security token is returned if user does have READ_TARGET_SEC_TOKEN permission.")
     @WithUser(allSpPermissions = false, authorities = { SpPermission.READ_TARGET, SpPermission.CREATE_TARGET,
             SpPermission.READ_TARGET_SEC_TOKEN })
     public void securityTokenIsInResponseWithCorrectPermission() throws Exception {
@@ -164,6 +162,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that that IP address is in result as stored in the repository.")
     public void addressAndIpAddressInTargetResult() throws Exception {
         // prepare targets with IP
         final String knownControllerId1 = "0815";
@@ -195,6 +194,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that actions history is returned as defined by filter status==pending,status==finished.")
     public void searchActionsRsql() throws Exception {
 
         // prepare test
@@ -227,6 +227,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that a deletion of an active action results in cancelation triggered.")
     public void cancelActionOK() throws Exception {
         // prepare test
         final Target tA = createTargetAndStartAction();
@@ -250,7 +251,8 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
-    public void cancelAnCancelActionIsNotAllowed() throws Exception {
+    @Description("Ensures that method not allowed is returned if cancelation is triggered on already canceled action.")
+    public void cancelAndCancelActionIsNotAllowed() throws Exception {
         // prepare test
         final Target tA = createTargetAndStartAction();
 
@@ -302,6 +304,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that deletion is executed if permitted.")
     public void deleteTargetReturnsOK() throws Exception {
         final String knownControllerId = "knownControllerIdDelete";
         targetManagement.createTarget(new Target(knownControllerId));
@@ -314,6 +317,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that deletion is refused with not found if target does not exist.")
     public void deleteTargetWhichDoesNotExistsLeadsToEntityNotFound() throws Exception {
         final String knownControllerId = "knownControllerIdDelete";
 
@@ -322,6 +326,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that update is refused with not found if target does not exist.")
     public void updateTargetWhichDoesNotExistsLeadsToEntityNotFound() throws Exception {
         final String knownControllerId = "knownControllerIdUpdate";
         mvc.perform(put(RestConstants.TARGET_V1_REQUEST_MAPPING + "/" + knownControllerId).content("{}")
@@ -330,6 +335,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that target update request is reflected by repository.")
     public void updateTargetDescription() throws Exception {
         final String knownControllerId = "123";
         final String knownNewDescription = "a new desc updated over rest";
@@ -354,6 +360,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that target query returns list of targets in defined format.")
     public void getTargetWithoutAddtionalRequestParameters() throws Exception {
         final int knownTargetAmount = 3;
         final String idA = "a";
@@ -393,6 +400,7 @@ public class TargetResourceTest extends AbstractIntegrationTest {
     }
 
     @Test
+    @Description("Ensures that target query returns list of targets in defined format in size reduced by given limit parameter.")
     public void getTargetWithPagingLimitRequestParameter() throws Exception {
         final int knownTargetAmount = 3;
         final int limitSize = 1;
@@ -413,10 +421,10 @@ public class TargetResourceTest extends AbstractIntegrationTest {
                 .andExpect(jsonPath("$content.[?(@.name==" + idA + ")][0].controllerId", equalTo(idA)))
                 .andExpect(jsonPath("$content.[?(@.name==" + idA + ")][0].createdBy", equalTo("bumlux")))
                 .andExpect(jsonPath("$content.[?(@.name==" + idA + ")][0].updateStatus", equalTo("unknown")));
-
     }
 
     @Test
+    @Description("Ensures that target query returns list of targets in defined format in size reduced by given limit and offset parameter.")
     public void getTargetWithPagingLimitAndOffsetRequestParameter() throws Exception {
         final int knownTargetAmount = 5;
         final int offsetParam = 2;

hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/tenantconfiguration/authentication/GatewaySecurityTokenAuthenticationConfigurationItem.java

@@ -84,8 +84,7 @@ public class GatewaySecurityTokenAuthenticationConfigurationItem extends Abstrac
         gatewayTokenNameTextField = SPUIComponentProvider.getTextField("", ValoTheme.TEXTFIELD_TINY, false, null, "",
                 true, SPUILabelDefinitions.TEXT_FIELD_MAX_LENGTH);
         gatewayTokenNameTextField.setImmediate(true);
-        // hide text field until we support multiple gateway tokens for a tenant
-        // MECS-830
+        // hide text field until we support multiple gateway tokens for a tenan
         gatewayTokenNameTextField.setVisible(false);
         gatewayTokenNameTextField.addTextChangeListener(event -> keyNameChanged());