diff --git a/hawkbit-autoconfigure/src/main/java/org/eclipse/hawkbit/autoconfigure/security/InMemoryUserManagementAutoConfiguration.java b/hawkbit-autoconfigure/src/main/java/org/eclipse/hawkbit/autoconfigure/security/InMemoryUserManagementAutoConfiguration.java index ef9b4b972..721365507 100644 --- a/hawkbit-autoconfigure/src/main/java/org/eclipse/hawkbit/autoconfigure/security/InMemoryUserManagementAutoConfiguration.java +++ b/hawkbit-autoconfigure/src/main/java/org/eclipse/hawkbit/autoconfigure/security/InMemoryUserManagementAutoConfiguration.java @@ -35,10 +35,8 @@ public class InMemoryUserManagementAutoConfiguration extends GlobalAuthenticatio private final StaticAuthenticationProvider authenticationProvider; InMemoryUserManagementAutoConfiguration(final SecurityProperties securityProperties, - final TenantAwareUserProperties tenantAwareUserProperties, - final Optional passwordEncoder) { - authenticationProvider = new StaticAuthenticationProvider(tenantAwareUserProperties, securityProperties, - passwordEncoder.orElse(null)); + final TenantAwareUserProperties tenantAwareUserProperties) { + authenticationProvider = new StaticAuthenticationProvider(tenantAwareUserProperties, securityProperties); } @Override diff --git a/hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/StaticAuthenticationProvider.java b/hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/StaticAuthenticationProvider.java index c0262a49b..b3e479c95 100644 --- a/hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/StaticAuthenticationProvider.java +++ b/hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/StaticAuthenticationProvider.java @@ -37,9 +37,8 @@ import java.util.regex.Pattern; public class StaticAuthenticationProvider extends DaoAuthenticationProvider { public StaticAuthenticationProvider( - final TenantAwareUserProperties tenantAwareUserProperties, final SecurityProperties securityProperties, - final PasswordEncoder passwordEncoder) { - setUserDetailsService(userDetailsService(securityProperties, tenantAwareUserProperties, passwordEncoder)); + final TenantAwareUserProperties tenantAwareUserProperties, final SecurityProperties securityProperties) { + setUserDetailsService(userDetailsService(securityProperties, tenantAwareUserProperties)); } @Override @@ -56,11 +55,10 @@ public class StaticAuthenticationProvider extends DaoAuthenticationProvider { private static UserDetailsService userDetailsService( final SecurityProperties securityProperties, - final TenantAwareUserProperties tenantAwareUserProperties, - final PasswordEncoder passwordEncoder) { + final TenantAwareUserProperties tenantAwareUserProperties) { final List userPrincipals = new ArrayList<>(); tenantAwareUserProperties.getUser().forEach((username, user) -> { - final String password = password(user.getPassword(), passwordEncoder); + final String password = password(user.getPassword()); final List credentials = createAuthorities(user.getRoles(), user.getPermissions(), Collections::emptyList); if (ObjectUtils.isEmpty(user.getTenant())) { @@ -75,7 +73,7 @@ public class StaticAuthenticationProvider extends DaoAuthenticationProvider { // explicitly setup system user - add is as a regular (non-tenant scoped) user userPrincipals.add(new User( securityProperties.getUser().getName(), - password(securityProperties.getUser().getPassword(), passwordEncoder), + password(securityProperties.getUser().getPassword()), createAuthorities( securityProperties.getUser().getRoles(), Collections.emptyList(), PermissionUtils::createAllAuthorityList))); @@ -84,9 +82,8 @@ public class StaticAuthenticationProvider extends DaoAuthenticationProvider { return new FixedInMemoryTenantAwareUserDetailsService(userPrincipals); } - private static String password(final String password, final PasswordEncoder passwordEncoder) { - return passwordEncoder == null && !Pattern.compile("^\\{.+}.*$").matcher(password).matches() ? - "{noop}" + password : password; + private static String password(final String password) { + return !Pattern.compile("^\\{.+}.*$").matcher(password).matches() ? "{noop}" + password : password; } private static List createAuthorities(