From 9bd47a5c555956265f0a0ffa13ac2e8c3930759a Mon Sep 17 00:00:00 2001
From: Gaurav <gaurav.sahay@in.bosch.com>
Date: Fri, 5 Aug 2016 10:49:24 +0200
Subject: [PATCH] Added the message in the message.properties. Signed-off-by:
 Gaurav <gaurav.sahay@in.bosch.com>

---
 .../detailslayout/SoftwareModuleDetailsTable.java      |  4 +---
 .../ui/distributions/dstable/DistributionSetTable.java | 10 ++++------
 hawkbit-ui/src/main/resources/messages.properties      |  1 +
 hawkbit-ui/src/main/resources/messages_de.properties   |  1 +
 hawkbit-ui/src/main/resources/messages_en.properties   |  1 +
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsTable.java
index 036b229df..a7adb8711 100644
--- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsTable.java
+++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/SoftwareModuleDetailsTable.java
@@ -187,9 +187,7 @@ public class SoftwareModuleDetailsTable extends Table {
             final Set<SoftwareModule> alreadyAssignedSwModules) {
         final SoftwareModule unAssignedSw = getSoftwareModule(event.getButton().getId(), alreadyAssignedSwModules);
         if (distributionSetManagement.isDistributionSetInUse(distributionSet)) {
-            uiNotification.displayValidationError(
-                    String.format("Distribution set %s:%s is already assigned to targets and cannot be changed",
-                            distributionSet.getName(), distributionSet.getVersion()));
+            uiNotification.displayValidationError(i18n.get("message.error.notification.ds.target.assigned",distributionSet.getName(), distributionSet.getVersion()));
         } else {
             final DistributionSet newDistributionSet = distributionSetManagement.unassignSoftwareModule(distributionSet,
                     unAssignedSw);
diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java
index 1547ef11b..fc415f4de 100644
--- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java
+++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java
@@ -334,9 +334,7 @@ public class DistributionSetTable extends AbstractNamedVersionTable<Distribution
         }
 
         if (distributionSetManagement.isDistributionSetInUse(ds)) {
-            notification.displayValidationError(
-                    String.format("Distribution set %s:%s is already assigned to targets and cannot be changed",
-                            ds.getName(), ds.getVersion()));
+            notification.displayValidationError(i18n.get("message.error.notification.ds.target.assigned", ds.getName(), ds.getVersion()));
             return false;
         }
         return true;
@@ -506,7 +504,7 @@ public class DistributionSetTable extends AbstractNamedVersionTable<Distribution
         return columnList;
     }
 
-    private Button createManageMetadataButton(String nameVersionStr) {
+    private Button createManageMetadataButton(final String nameVersionStr) {
         final Button manageMetadataBtn = SPUIComponentProvider.getButton(
                 SPUIComponentIdProvider.DS_TABLE_MANAGE_METADATA_ID + "." + nameVersionStr, "", "", null, false,
                 FontAwesome.LIST_ALT, SPUIButtonStyleSmallNoBorder.class);
@@ -515,8 +513,8 @@ public class DistributionSetTable extends AbstractNamedVersionTable<Distribution
         return manageMetadataBtn;
     }
 
-    private void showMetadataDetails(Long itemId) {
-        DistributionSet ds = distributionSetManagement.findDistributionSetByIdWithDetails(itemId);
+    private void showMetadataDetails(final Long itemId) {
+        final DistributionSet ds = distributionSetManagement.findDistributionSetByIdWithDetails(itemId);
         UI.getCurrent().addWindow(dsMetadataPopupLayout.getWindow(ds,null));
     }
 
diff --git a/hawkbit-ui/src/main/resources/messages.properties b/hawkbit-ui/src/main/resources/messages.properties
index 383341f4f..bb399ddf1 100644
--- a/hawkbit-ui/src/main/resources/messages.properties
+++ b/hawkbit-ui/src/main/resources/messages.properties
@@ -386,6 +386,7 @@ message.metadata.updated = Metadata with key {0} successfully updated !
 message.metadata.duplicate.check = Metadata with key {0} already exists, please enter another value
 message.metadata.deleted.successfully = Metadata with key {0} successfully deleted !
 message.confirm.delete.metadata = Are you sure that you want to delete metadata with key {0} ?
+message.error.notification.ds.target.assigned = Distribution set {0}:{1} is already assigned to targets and cannot be changed
 
 # Login view
 notification.login.title=Welcome to Bosch IoT Software Provisioning.
diff --git a/hawkbit-ui/src/main/resources/messages_de.properties b/hawkbit-ui/src/main/resources/messages_de.properties
index cec24e1d8..fa62091fd 100644
--- a/hawkbit-ui/src/main/resources/messages_de.properties
+++ b/hawkbit-ui/src/main/resources/messages_de.properties
@@ -375,6 +375,7 @@ message.metadata.updated = Metadata with key {0} successfully updated !
 message.metadata.duplicate.check = Metadata with key {0} already exists, please enter another value
 message.metadata.deleted.successfully = Metadata with key {0} successfully deleted !
 message.confirm.delete.metadata = Are you sure that you want to delete metadata with key {0} ?
+message.error.notification.ds.target.assigned = Distribution set {0}:{1} is already assigned to targets and cannot be changed
 
 
 # Login view
diff --git a/hawkbit-ui/src/main/resources/messages_en.properties b/hawkbit-ui/src/main/resources/messages_en.properties
index dbb2b5c6f..65e63c228 100644
--- a/hawkbit-ui/src/main/resources/messages_en.properties
+++ b/hawkbit-ui/src/main/resources/messages_en.properties
@@ -371,6 +371,7 @@ message.metadata.updated = Metadata with key {0} successfully updated !
 message.metadata.duplicate.check = Metadata with key {0} already exists, please enter another value
 message.metadata.deleted.successfully = Metadata with key {0} successfully deleted !
 message.confirm.delete.metadata = Are you sure that you want to delete metadata with key {0} ?
+message.error.notification.ds.target.assigned = Distribution set {0}:{1} is already assigned to targets and cannot be changed
 
 # Login view
 notification.login.title=Welcome to Bosch IoT Software Provisioning.