From 6fcdc5408b57bd73be8b35d34daff55fd96cf89f Mon Sep 17 00:00:00 2001
From: Markus Block <markus.block@bosch-si.com>
Date: Thu, 1 Mar 2018 14:45:21 +0100
Subject: [PATCH] Fix missing message property (#646)

* Added missing message property when dragging a software module twice to
a distribution without saving.

Signed-off-by: Markus Block <markus.block@bosch-si.com>

* Added null check in case the item dragged was released not over a
distribution set to avoid a NPE.

Signed-off-by: Markus Block <markus.block@bosch-si.com>
---
 .../ui/distributions/dstable/DistributionSetTable.java        | 4 +++-
 hawkbit-ui/src/main/resources/messages.properties             | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java
index 8b56586e6..de6477eec 100644
--- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java
+++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/dstable/DistributionSetTable.java
@@ -222,7 +222,9 @@ public class DistributionSetTable extends AbstractNamedVersionTable<Distribution
         final AbstractSelectTargetDetails dropData = (AbstractSelectTargetDetails) event.getTargetDetails();
 
         final Object distItemId = dropData.getItemIdOver();
-        handleDropEvent(source, softwareModulesIdList, distItemId);
+        if (distItemId != null) {
+            handleDropEvent(source, softwareModulesIdList, distItemId);
+        }
     }
 
     @Override
diff --git a/hawkbit-ui/src/main/resources/messages.properties b/hawkbit-ui/src/main/resources/messages.properties
index fc470bcf9..2a3e53146 100644
--- a/hawkbit-ui/src/main/resources/messages.properties
+++ b/hawkbit-ui/src/main/resources/messages.properties
@@ -426,6 +426,7 @@ message.software.assignment = {0} Software Module(s) Assignment(s) done
 message.dist.inuse = Distribution {0} is already assigned to target
 message.software.dist.already.assigned = Software Module {0} is already assigned to Distribution {1}
 message.software.dist.type.notallowed = Software Module {0} cannot be assigned, because Distribution {1} does not support the Software Module Type {2}
+message.software.already.dragged = Software Module {0} was already dragged to this Distribution.
 message.target.assigned =  {0} is assigned to {1}
 message.dist.type.delete = {0} Distribution Type(s) deleted successfully.
 message.sw.module.type.delete = {0} Software Module Type(s) deleted successfully.