Fix license scan workflow (#2506) (#2507)

Signed-off-by: Avgustin Marinov <Avgustin.Marinov@bosch.com>

.github/workflows/license-scan.yaml

@@ -21,4 +21,4 @@ jobs:
         ref: ${{ github.ref }}
         open_tickets: true
     secrets:
-      inherit: true
+      GITLAB_API_TOKEN: ${{ secrets.GITLAB_API_TOKEN }}

.github/workflows/reusable_workflow_license-scan.yaml

@@ -73,9 +73,7 @@ jobs:
             fi
           fi
           # do dash.fail=true so if there are restricted dependencies the build will fail
-          mvn license-tool:license-check -Ddash.fail=true -PcheckLicense -Ddash.iplab.token=${GITLAB_API_TOKEN} --projects '!org.eclipse.hawkbit:hawkbit-repository-test,!org.eclipse.hawkbit:hawkbit-dmf-rabbitmq-test'
+          mvn license-tool:license-check -Ddash.fail=true -PcheckLicense -Ddash.iplab.token=${{ secrets.GITLAB_API_TOKEN }} --projects '!org.eclipse.hawkbit:hawkbit-repository-test,!org.eclipse.hawkbit:hawkbit-dmf-rabbitmq-test'
-        env:
-          GITLAB_API_TOKEN: ${{ secrets.GITLAB_API_TOKEN }}
 
       - name: Check dependency licenses with dash tool (and return the result)
         run: mvn license-tool:license-check -Ddash.fail=true -PcheckLicense --projects '!org.eclipse.hawkbit:hawkbit-repository-test,!org.eclipse.hawkbit:hawkbit-dmf-rabbitmq-test'

.github/workflows/reusable_workflow_tag.yaml

@@ -1,4 +1,4 @@
-name: Tag
+name: Tag (Reusable Workflow)
 
 on:
   workflow_call:

.github/workflows/reusable_workflow_trivy-scan.yaml

@@ -68,41 +68,35 @@ jobs:
             exit 0
           fi
 
-      - name: Upload Docker image scan results to GitHub Security tab hawkbit-ddi-server (hawkbit-ddi-server)
+      - name: Upload Docker image scan results to GitHub Security tab hawkbit-ddi-server
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-ddi-server:latest.sarif'
           category: "Container Images (hawkbit-ddi-server)"
-      - name: Upload Docker image scan results to GitHub Security tab hawkbit-dmf-server (hawkbit-dmf-server)
+      - name: Upload Docker image scan results to GitHub Security tab hawkbit-dmf-server
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-dmf-server:latest.sarif'
           category: "Container Images (hawkbit-dmf-server)"
-      - name: Upload Docker image scan results to GitHub Security tab hawkbit-mgmt-server (hawkbit-mgmt-server)
+      - name: Upload Docker image scan results to GitHub Security tab hawkbit-mgmt-server
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-mgmt-server:latest.sarif'
           category: "Container Images (hawkbit-mgmt-server)"
-      - name: Upload Docker image scan results to GitHub Security tab hawkbit-simple-ui (hawkbit-simple-ui)
+      - name: Upload Docker image scan results to GitHub Security tab hawkbit-simple-ui
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-simple-ui:latest.sarif'
           category: "Container Images (hawkbit-simple-ui)"
 
-      - name: Upload Docker image scan results to GitHub Security tab (hawkbit-update-server)
+      - name: Upload Docker image scan results to GitHub Security tab hawkbit-update-server
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-update-server:latest.sarif'
           category: "Container Images (hawkbit-update-server)"
 
-      - name: Upload Docker image scan results to GitHub Security tab (hawkbit-repository-jpa-init)
+      - name: Upload Docker image scan results to GitHub Security tab hawkbit-repository-jpa-init
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-repository-jpa-init:latest.sarif'
           category: "Container Images (hawkbit-update-server)"
-
-      - name: Upload Docker image scan results to GitHub Security tab (hawkbit-repository-jpa-init)
-        uses: github/codeql-action/upload-sarif@v3
-        with:
-          sarif_file: 'scans/eclipse-hawkbit/hawkbit/hawkbit-repository-jpa-init:latest.sarif'
-          category: "Container Images (hawkbit-repository-jpa-init)"