lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fixing newly created bug by trying to simplify if-statement with commit

Browse Source 
a4e1ae7ac8

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
This commit is contained in:
Michael Hirsch
2016-02-10 12:43:54 +01:00
parent 0eadf537cc
commit 6a93b15854
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/dstable/DistributionAddUpdateWindowLayout.java
View File

@@ -344,21 +344,22 @@ public class DistributionAddUpdateWindowLayout extends VerticalLayout {
private boolean duplicateCheck(final String name, final String version) { private boolean duplicateCheck(final String name, final String version) {
final DistributionSet existingDs = distributionSetManagement.findDistributionSetByNameAndVersion(name, version); final DistributionSet existingDs = distributionSetManagement.findDistributionSetByNameAndVersion(name, version);
/*
if (existingDs == null) { * Distribution should not exists with the same name & version. Display
return true; * error message, when the "existingDs" is not null and it is add window
} * (or) when the "existingDs" is not null and it is edit window and the
* distribution Id of the edit window is different then the "existingDs"
if (editDistribution && !existingDs.getId().equals(editDistId)) { */
return true; if (existingDs != null && !existingDs.getId().equals(editDistId)) {
}
distNameTextField.addStyleName("v-textfield-error"); distNameTextField.addStyleName("v-textfield-error");
distVersionTextField.addStyleName("v-textfield-error"); distVersionTextField.addStyleName("v-textfield-error");
notificationMessage.displayValidationError( notificationMessage.displayValidationError(
i18n.get("message.duplicate.dist", new Object[] { existingDs.getName(), existingDs.getVersion() })); i18n.get("message.duplicate.dist", new Object[] { existingDs.getName(), existingDs.getVersion() }));
return false; return false;
} else {
return true;
}
} }
/** /**