From 61378b1f5cae6468e5a02e72e8c63184ab9cc2be Mon Sep 17 00:00:00 2001 From: Robert Sing <50371841+singrob@users.noreply.github.com> Date: Wed, 31 Jul 2019 09:29:23 +0200 Subject: [PATCH] fixed NullPointerException in deployment view (#871) * fixed NullPointer exception in deployment view Signed-off-by: Robert Sing * fixed review findings Signed-off-by: Robert Sing --- .../hawkbit/ui/management/DeploymentView.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/DeploymentView.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/DeploymentView.java index 6c4cb34e5..170c74664 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/DeploymentView.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/DeploymentView.java @@ -407,11 +407,15 @@ public class DeploymentView extends AbstractNotificationView implements BrowserW protected Map, RefreshableContainer> getSupportedPushEvents() { final Map, RefreshableContainer> supportedEvents = Maps.newHashMapWithExpectedSize(10); - supportedEvents.put(TargetCreatedEventContainer.class, targetTableLayout.getTable()); - supportedEvents.put(TargetDeletedEventContainer.class, targetTableLayout.getTable()); + if (permChecker.hasTargetReadPermission()) { + supportedEvents.put(TargetCreatedEventContainer.class, targetTableLayout.getTable()); + supportedEvents.put(TargetDeletedEventContainer.class, targetTableLayout.getTable()); + } - supportedEvents.put(DistributionSetCreatedEventContainer.class, distributionTableLayout.getTable()); - supportedEvents.put(DistributionSetDeletedEventContainer.class, distributionTableLayout.getTable()); + if (permChecker.hasReadRepositoryPermission()) { + supportedEvents.put(DistributionSetCreatedEventContainer.class, distributionTableLayout.getTable()); + supportedEvents.put(DistributionSetDeletedEventContainer.class, distributionTableLayout.getTable()); + } supportedEvents.put(TargetTagCreatedEventContainer.class, targetTagFilterLayout); supportedEvents.put(TargetTagDeletedEventContainer.class, targetTagFilterLayout);