From 60fbabbc62c435fbdd4fe4099beefc30ee8b9cbb Mon Sep 17 00:00:00 2001 From: Stanislav Trailov Date: Mon, 17 Jul 2023 17:12:21 +0300 Subject: [PATCH] fix sonar finding (#1398) Signed-off-by: Stanislav Trailov --- .../distributionset/MgmtDistributionSetStatistics.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hawkbit-rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtDistributionSetStatistics.java b/hawkbit-rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtDistributionSetStatistics.java index 652761674..fdf40e456 100644 --- a/hawkbit-rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtDistributionSetStatistics.java +++ b/hawkbit-rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtDistributionSetStatistics.java @@ -76,7 +76,7 @@ public class MgmtDistributionSetStatistics { MgmtDistributionSetStatistics statistics = new MgmtDistributionSetStatistics(); statistics.totalActionsPerStatus = calculateTotalWithStatus(totalActionsPerStatus); statistics.totalRolloutsPerStatus = calculateTotalWithStatus(totalRolloutsPerStatus); - statistics.totalAutoAssignments = fullRepresentation ? (totalAutoAssignments == null ? Long.valueOf(0) : totalAutoAssignments) : totalAutoAssignments; + statistics.totalAutoAssignments = calculateTotalAutoAssignments(); return statistics; } @@ -89,6 +89,14 @@ public class MgmtDistributionSetStatistics { statusMap.put(TOTAL, total); return statusMap; } + + private Long calculateTotalAutoAssignments() { + if (fullRepresentation) { + return totalAutoAssignments == null ? Long.valueOf(0) : totalAutoAssignments; + } + + return totalAutoAssignments; + } } }