clean code do early return.

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
This commit is contained in:
Michael Hirsch
2016-03-02 09:00:10 +01:00
parent 229e7c54af
commit 5efcc295bc

View File

@@ -143,12 +143,13 @@ public class DelayedEventBusPushStrategy implements EventPushStrategy {
*/ */
protected boolean eventSecurityCheck(final SecurityContext userContext, protected boolean eventSecurityCheck(final SecurityContext userContext,
final org.eclipse.hawkbit.eventbus.event.Event event) { final org.eclipse.hawkbit.eventbus.event.Event event) {
if (userContext != null && userContext.getAuthentication() != null) { if (userContext == null || userContext.getAuthentication() == null) {
final Object tenantAuthenticationDetails = userContext.getAuthentication().getDetails(); return false;
if (tenantAuthenticationDetails instanceof TenantAwareAuthenticationDetails) { }
return ((TenantAwareAuthenticationDetails) tenantAuthenticationDetails).getTenant() final Object tenantAuthenticationDetails = userContext.getAuthentication().getDetails();
.equalsIgnoreCase(event.getTenant()); if (tenantAuthenticationDetails instanceof TenantAwareAuthenticationDetails) {
} return ((TenantAwareAuthenticationDetails) tenantAuthenticationDetails).getTenant()
.equalsIgnoreCase(event.getTenant());
} }
return false; return false;
} }