diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/table/AbstractTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/table/AbstractTable.java index b3b74836c..e8bb18e90 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/table/AbstractTable.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/table/AbstractTable.java @@ -26,8 +26,6 @@ import org.eclipse.hawkbit.ui.utils.SPDateTimeUtil; import org.eclipse.hawkbit.ui.utils.SPUIDefinitions; import org.eclipse.hawkbit.ui.utils.SPUILabelDefinitions; import org.eclipse.hawkbit.ui.utils.TableColumn; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.vaadin.spring.events.EventBus; @@ -49,9 +47,9 @@ import com.vaadin.ui.themes.ValoTheme; */ public abstract class AbstractTable extends Table { - private static final long serialVersionUID = 4856562746502217630L; + private static final float DEFAULT_COLUMN_NAME_MIN_SIZE = 0.8F; - private static final Logger LOG = LoggerFactory.getLogger(AbstractTable.class); + private static final long serialVersionUID = 4856562746502217630L; @Autowired protected transient EventBus.SessionEventBus eventBus; @@ -89,6 +87,13 @@ public abstract class AbstractTable extends Table { eventBus.unsubscribe(this); } + /** + * Gets the selected item id or in multiselect mode a set of selected ids. + * + * @param table + * the table to retrieve the selected ID(s) + * @return the ID(s) which are selected in the table + */ public static Set getTableValue(final Table table) { @SuppressWarnings("unchecked") Set values = (Set) table.getValue(); @@ -351,7 +356,7 @@ public abstract class AbstractTable extends Table { } protected float getColumnNameMinimizedSize() { - return 0.8F; + return DEFAULT_COLUMN_NAME_MIN_SIZE; } /** diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java index 0a70f60d5..4e43ea39b 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java @@ -899,6 +899,7 @@ public class TargetTable extends AbstractTable { /** * Select all rows in the table. */ + @Override public void selectAll() { // As Vaadin Table only returns the current ItemIds which are visible @@ -999,4 +1000,4 @@ public class TargetTable extends AbstractTable { private boolean isFilteredByTags() { return !managementUIState.getTargetTableFilters().getClickedTargetTags().isEmpty(); } -} \ No newline at end of file +}