Code cleanup (#427)

* Removed dead code.

Signed-off-by: kaizimmerm <kai.zimmermann@bosch-si.com>

* Fix sonar issues.

Signed-off-by: kaizimmerm <kai.zimmermann@bosch-si.com>

hawkbit-repository/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/exception/ToManyAttributeEntriesException.java

@@ -13,10 +13,6 @@ import org.eclipse.hawkbit.exception.SpServerError;
 
 /**
  * Thrown if too many status entries have been inserted.
- *
- *
- *
- *
  */
 public final class ToManyAttributeEntriesException extends AbstractServerRtException {
     /**

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/AbstractJpaNamedEntity.java

@@ -51,7 +51,7 @@ public abstract class AbstractJpaNamedEntity extends AbstractJpaTenantAwareBaseE
      * @param description
      *            of the {@link NamedEntity}
      */
-    public AbstractJpaNamedEntity(final String name, final String description) {
+    AbstractJpaNamedEntity(final String name, final String description) {
         this.name = name;
         this.description = description;
     }

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/AbstractJpaNamedVersionedEntity.java

@@ -41,7 +41,7 @@ public abstract class AbstractJpaNamedVersionedEntity extends AbstractJpaNamedEn
      *            of the entity
      * @param description
      */
-    public AbstractJpaNamedVersionedEntity(final String name, final String version, final String description) {
+    AbstractJpaNamedVersionedEntity(final String name, final String version, final String description) {
         super(name, description);
         this.version = version;
     }

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/AbstractJpaTenantAwareBaseEntity.java

@@ -47,7 +47,7 @@ public abstract class AbstractJpaTenantAwareBaseEntity extends AbstractJpaBaseEn
      * entities.
      */
     @PrePersist
-    public void prePersist() {
+    void prePersist() {
         // before persisting the entity check the current ID of the tenant by
         // using the TenantAware
         // service

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/DistributionSetTypeElement.java

@@ -66,7 +66,7 @@ public class DistributionSetTypeElement implements Serializable {
      *            to <code>true</code> if the {@link SoftwareModuleType} if
      *            mandatory element in the {@link DistributionSet}.
      */
-    public DistributionSetTypeElement(final JpaDistributionSetType dsType, final JpaSoftwareModuleType smType,
+    DistributionSetTypeElement(final JpaDistributionSetType dsType, final JpaSoftwareModuleType smType,
             final boolean mandatory) {
         super();
         key = new DistributionSetTypeElementCompositeKey(dsType, smType);
@@ -75,7 +75,7 @@ public class DistributionSetTypeElement implements Serializable {
         this.mandatory = mandatory;
     }
 
-    public DistributionSetTypeElement setMandatory(final boolean mandatory) {
+    DistributionSetTypeElement setMandatory(final boolean mandatory) {
         this.mandatory = mandatory;
         return this;
     }

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaActionStatus.java

@@ -117,22 +117,6 @@ public class JpaActionStatus extends AbstractJpaTenantAwareBaseEntity implements
         this.occurredAt = occurredAt;
     }
 
-    /**
-     * Creates a new {@link ActionStatus} object.
-     *
-     * @param status
-     *            the status for this action status
-     * @param occurredAt
-     *            the occurred timestamp
-     * @param message
-     *            the message which should be added to this action status
-     */
-    public JpaActionStatus(final Status status, final Long occurredAt, final String message) {
-        this.status = status;
-        this.occurredAt = occurredAt;
-        addMessage(message);
-    }
-
     /**
      * JPA default constructor.
      */

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaDistributionSetTag.java

@@ -41,16 +41,6 @@ public class JpaDistributionSetTag extends JpaTag implements DistributionSetTag,
     @ManyToMany(mappedBy = "tags", targetEntity = JpaDistributionSet.class, fetch = FetchType.LAZY)
     private List<DistributionSet> assignedToDistributionSet;
 
-    /**
-     * Public constructor.
-     *
-     * @param name
-     *            of the {@link DistributionSetTag}
-     **/
-    public JpaDistributionSetTag(final String name) {
-        super(name, null, null);
-    }
-
     /**
      * Public constructor.
      *

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaTargetFilterQuery.java

@@ -56,19 +56,6 @@ public class JpaTargetFilterQuery extends AbstractJpaTenantAwareBaseEntity imple
         // Default constructor for JPA.
     }
 
-    /**
-     * Public constructor.
-     * 
-     * @param name
-     *            of the {@link TargetFilterQuery}.
-     * @param query
-     *            of the {@link TargetFilterQuery}.
-     */
-    public JpaTargetFilterQuery(final String name, final String query) {
-        this.name = name;
-        this.query = query;
-    }
-
     /**
      * Construct a Target filter query with auto assign distribution set
      * 

hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/model/JpaTargetTag.java

@@ -55,16 +55,6 @@ public class JpaTargetTag extends JpaTag implements TargetTag, EventAwareEntity
         super(name, description, colour);
     }
 
-    /**
-     * Public constructor.
-     *
-     * @param name
-     *            of the {@link TargetTag}
-     **/
-    public JpaTargetTag(final String name) {
-        super(name, null, null);
-    }
-
     public JpaTargetTag() {
         // Default constructor for JPA.
     }