Expose approval remark and decided by in rollout mgmt API (#1389)
Signed-off-by: Stanislav Trailov <Stanislav.Trailov@bosch.io>
This commit is contained in:
committed by
GitHub
parent
3402808ee9
commit
593a0bb146
@@ -19,6 +19,8 @@ public class RolloutTestApprovalStrategy implements RolloutApprovalStrategy {
|
||||
|
||||
private boolean approvalNeeded = false;
|
||||
|
||||
private String approvalDecidedBy;
|
||||
|
||||
@Override
|
||||
public boolean isApprovalNeeded(Rollout rollout) {
|
||||
return approvalNeeded;
|
||||
@@ -28,6 +30,10 @@ public class RolloutTestApprovalStrategy implements RolloutApprovalStrategy {
|
||||
this.approvalNeeded = approvalNeeded;
|
||||
}
|
||||
|
||||
public void setApproveDecidedBy(final String user) {
|
||||
this.approvalDecidedBy = user;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onApprovalRequired(Rollout rollout) {
|
||||
// do nothing, as no action is needed when testing
|
||||
@@ -35,6 +41,6 @@ public class RolloutTestApprovalStrategy implements RolloutApprovalStrategy {
|
||||
|
||||
@Override
|
||||
public String getApprovalUser(Rollout rollout) {
|
||||
return null;
|
||||
return approvalDecidedBy;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user