lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Remove target type to target reference (#1771)

Browse Source 
it is not used and could lead to extensive memory usage if JPA provider load targets while loading types

Signed-off-by: Marinov Avgustin <Avgustin.Marinov@bosch.com>
This commit is contained in:
Avgustin Marinov
2024-07-18 18:13:03 +03:00
committed by GitHub
parent bb288eab6b
commit 56ab399493
7 changed files with 33 additions and 249 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/acm/controller/TargetTypeAccessControllerTest.java
View File

@@ -67,31 +67,6 @@ class TargetTypeAccessControllerTest extends AbstractAccessControllerTest {
assertThat(targetTypeManagement.findByRsql(Pageable.unpaged(), "id==*").get().map(Identifiable::getId).toList())
.containsOnly(permittedTargetType.getId());
// verify targetTypeManagement#findByTargetControllerId
assertThat(targetTypeManagement.findByTargetControllerId(targetWithPermittedTargetType.getControllerId()))
.hasValueSatisfying(foundType -> assertThat(foundType.getId()).isEqualTo(permittedTargetType.getId()));
assertThat(targetTypeManagement.findByTargetControllerId(targetWithHiddenTargetType.getControllerId()))
.isEmpty();
// verify targetTypeManagement#findByTargetControllerIds
assertThat(
targetTypeManagement
.findByTargetControllerIds(Arrays.asList(targetWithPermittedTargetType.getControllerId(),
targetWithHiddenTargetType.getControllerId()))
.stream().map(Identifiable::getId).toList())
.hasSize(1).containsOnly(permittedTargetType.getId());
// verify targetTypeManagement#findByTargetId
assertThat(targetTypeManagement.findByTargetId(targetWithPermittedTargetType.getId()))
.hasValueSatisfying(foundType -> assertThat(foundType.getId()).isEqualTo(permittedTargetType.getId()));
assertThat(targetTypeManagement.findByTargetId(targetWithHiddenTargetType.getId())).isEmpty();
// verify targetTypeManagement#findByTargetIds
assertThat(targetTypeManagement
.findByTargetIds(
Arrays.asList(targetWithPermittedTargetType.getId(), targetWithHiddenTargetType.getId()))
.stream().map(Identifiable::getId).toList()).hasSize(1).containsOnly(permittedTargetType.getId());
// verify targetTypeManagement#findByName
assertThat(targetTypeManagement.findByName(Pageable.unpaged(), permittedTargetType.getName()).getContent())
.hasSize(1).satisfies(results -> {