lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Refactoring: Extract some staff to private methods and remove duplicated

Browse Source 
code

Signed-off-by: SirWayne <dennis.melzer@bosch-si.com>
This commit is contained in:
SirWayne
2016-04-13 17:37:55 +02:00
parent d21485cad4
commit 4b6a6a4a4a
1 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/footer/DeleteActionsLayout.java
View File

@@ -278,14 +278,27 @@ public class DeleteActionsLayout extends AbstractDeleteActionsLayout {
managementUIState.getDeletedDistributionList().addAll(distributionIdNameSet); managementUIState.getDeletedDistributionList().addAll(distributionIdNameSet);
final int newDeletedDistributionsSize = managementUIState.getDeletedDistributionList().size(); final int newDeletedDistributionsSize = managementUIState.getDeletedDistributionList().size();
if (newDeletedDistributionsSize == existingDeletedDistributionsSize) { showAlreadyDeletedDistributionSetNotfication(existingDeletedDistributionsSize, newDeletedDistributionsSize,
notification.displayValidationError(i18n.get("message.targets.already.deleted")); "message.dists.already.deleted");
showPendingDeletedNotifaction(distributionIdNameSet, existingDeletedDistributionsSize,
newDeletedDistributionsSize, "message.dist.deleted.pending");
}
private void showPendingDeletedNotifaction(final Set<?> currentValues, final int existingDeletedSize,
final int newDeletedSize, final String messageKey) {
if (newDeletedSize - existingDeletedSize == currentValues.size()) {
return; return;
} }
notification.displayValidationError(i18n.get(messageKey));
}
if (newDeletedDistributionsSize - existingDeletedDistributionsSize != distributionIdNameSet.size()) { private void showAlreadyDeletedDistributionSetNotfication(final int existingDeletedSize, final int newDeletedSize,
notification.displayValidationError(i18n.get("message.dist.deleted.pending")); final String messageKey) {
if (newDeletedSize != existingDeletedSize) {
return;
} }
notification.displayValidationError(i18n.get(messageKey));
} }
private boolean isDsInUseInBulkUpload(final Set<DistributionSetIdName> distributionIdNameSet, private boolean isDsInUseInBulkUpload(final Set<DistributionSetIdName> distributionIdNameSet,
@@ -311,15 +324,11 @@ public class DeleteActionsLayout extends AbstractDeleteActionsLayout {
managementUIState.getDeletedTargetList().addAll(targetIdNameSet); managementUIState.getDeletedTargetList().addAll(targetIdNameSet);
final int newDeletedTargetsSize = managementUIState.getDeletedTargetList().size(); final int newDeletedTargetsSize = managementUIState.getDeletedTargetList().size();
if (newDeletedTargetsSize == existingDeletedTargetsSize) { showAlreadyDeletedDistributionSetNotfication(existingDeletedTargetsSize, newDeletedTargetsSize,
notification.displayValidationError(i18n.get("message.targets.already.deleted")); "message.targets.already.deleted");
return;
}
if (newDeletedTargetsSize - existingDeletedTargetsSize != targetIdNameSet.size()) { showPendingDeletedNotifaction(targetIdNameSet, existingDeletedTargetsSize, newDeletedTargetsSize,
notification.displayValidationError(i18n.get("message.target.deleted.pending")); "message.target.deleted.pending");
return;
}
} }
private void updateActionCount() { private void updateActionCount() {