Feature/fix sonar warnings (#1226)

* Fixed sonar warnings

- "Cognitive Complexity"
- "Do not use replaceAll when not using a regex"
- java:S5869 - Character classes in regular expressions should not contain the same character twice
- Improved bad name
- Typos
- reduced code duplications
- Replaced hand-made wait-utility with Awaitility
- Log messages
- Duplicate code
- Typos
- Removed Thread.sleep, instead relaxed check condition
- Removed use of deprecated API
- Removed use of deprecated API
- Added supress-warnings as I do not see a better way to write the tests
- Removed Thread.sleep / redundant functionality to Awaitility
- Fixed other warnings (use isZero, isEmpty, hasToString)
- Removed/Reduced duplicate code
- Added generics
- Fixed asserts
- removed: field.setAccessible(true) actually should not be needed for public static fields!
- Too long constructor passes arguments in wrong order - how surprisingly...
- Clean-up use of varargs arguments
- Fixed regex
- Fixed typos and other minor stuff
- Making public constructors protected in abstract classes
- Swapped expected and asserted argument
- volatile not enough for syncing threads
- volatile not enough for syncing threads
- out-commented code
- Made regex not-greedy, added tests for verification
- Avoid exposure of thread-local member var

Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>

* Fixed Sonar warnings

* License header fix

Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>

* License header fix #2

Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>

* Fixing review findings

Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>

* Fixing tests

- Fixed '&' usage in javadoc and typos
- Fixing some warnings

Signed-off-by: Peter Vigier <Peter.Vigier@bosch.io>

hawkbit-artifact-repository-filesystem/src/main/java/org/eclipse/hawkbit/artifact/repository/ArtifactFileNotFoundException.java

@@ -0,0 +1,23 @@
+/**
+ * Copyright (c) 2022 Bosch.IO GmbH and others.
+ *
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.eclipse.hawkbit.artifact.repository;
+
+/**
+ * Exception thrown in case that the artifact could not be read.
+ */
+public class ArtifactFileNotFoundException extends RuntimeException {
+
+    /**
+     * Creates the Exception from it's cause
+     * @param cause the original exception
+     */
+    public ArtifactFileNotFoundException(final Exception cause) {
+        super(cause);
+    }
+}

hawkbit-artifact-repository-filesystem/src/main/java/org/eclipse/hawkbit/artifact/repository/ArtifactFilesystem.java

@@ -13,12 +13,12 @@ import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.InputStream;
+import java.util.Objects;
+
+import javax.validation.constraints.NotNull;
 
 import org.eclipse.hawkbit.artifact.repository.model.AbstractDbArtifact;
 import org.eclipse.hawkbit.artifact.repository.model.DbArtifactHash;
-import org.springframework.util.Assert;
-
-import com.google.common.base.Throwables;
 
 /**
  * {@link AbstractDbArtifact} implementation which dynamically creates a
@@ -28,11 +28,11 @@ public class ArtifactFilesystem extends AbstractDbArtifact {
 
     private final File file;
 
-    public ArtifactFilesystem(final File file, final String artifactId, final DbArtifactHash hashes, final Long size,
+    public ArtifactFilesystem(@NotNull final File file, @NotNull final String artifactId,
+            @NotNull final DbArtifactHash hashes, final Long size,
             final String contentType) {
         super(artifactId, hashes, size, contentType);
-        Assert.notNull(file, "File cannot be null");
-        this.file = file;
+        this.file = Objects.requireNonNull(file, "Artifact file may not be null");
     }
 
     @Override
@@ -43,7 +43,7 @@ public class ArtifactFilesystem extends AbstractDbArtifact {
         try {
             return new BufferedInputStream(new FileInputStream(file));
         } catch (final FileNotFoundException e) {
-            throw Throwables.propagate(e);
+            throw new ArtifactFileNotFoundException(e);
         }
     }
 }