lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Sonar findings - TargetFilterQueryManagementTest fix no assert (#1998)

Browse Source 
Signed-off-by: Avgustin Marinov <Avgustin.Marinov@bosch.com>
This commit is contained in:
Avgustin Marinov
2024-11-09 23:41:09 +02:00
committed by GitHub
parent 7e6476a73f
commit 445c15ac3b
1 changed files with 23 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/management/TargetFilterQueryManagementTest.java
View File

@@ -354,10 +354,14 @@ public class TargetFilterQueryManagementTest extends AbstractJpaIntegrationTest
final Long filterId = targetFilterQueryManagement final Long filterId = targetFilterQueryManagement
.create(entityFactory.targetFilterQuery().create().name("a").query("name==*")).getId(); .create(entityFactory.targetFilterQuery().create().name("a").query("name==*")).getId();
targetFilterQueryManagement.create( assertThat(
entityFactory.targetFilterQuery().create().name("b").query("name==*").autoAssignDistributionSet(ds)); targetFilterQueryManagement.create(
targetFilterQueryManagement entityFactory.targetFilterQuery().create().name("b").query("name==*").autoAssignDistributionSet(ds)))
.updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId())); .isNotNull();
assertThat(
targetFilterQueryManagement
.updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId())))
.isNotNull();
} }
@Test @Test
@@ -367,10 +371,15 @@ public class TargetFilterQueryManagementTest extends AbstractJpaIntegrationTest
final Long filterId = targetFilterQueryManagement final Long filterId = targetFilterQueryManagement
.create(entityFactory.targetFilterQuery().create().name("a").query("name==*")).getId(); .create(entityFactory.targetFilterQuery().create().name("a").query("name==*")).getId();
targetFilterQueryManagement.create(entityFactory.targetFilterQuery().create() assertThat(
.name("b").query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(342)); targetFilterQueryManagement.create(
targetFilterQueryManagement.updateAutoAssignDS( entityFactory.targetFilterQuery().create()
entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId()).weight(343)); .name("b").query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(342)))
.isNotNull();
assertThat(
targetFilterQueryManagement.updateAutoAssignDS(
entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId()).weight(343)))
.isNotNull();
} }
@Test @Test
@@ -378,10 +387,13 @@ public class TargetFilterQueryManagementTest extends AbstractJpaIntegrationTest
public void removeDsFromFilterWhenMultiAssignmentModeNotEnabled() { public void removeDsFromFilterWhenMultiAssignmentModeNotEnabled() {
enableMultiAssignments(); enableMultiAssignments();
final DistributionSet ds = testdataFactory.createDistributionSet(); final DistributionSet ds = testdataFactory.createDistributionSet();
final Long filterId = targetFilterQueryManagement.create(entityFactory.targetFilterQuery().create().name("a") final Long filterId = targetFilterQueryManagement
.create(entityFactory.targetFilterQuery().create().name("a")
.query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(23)).getId(); .query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(23)).getId();
targetFilterQueryManagement assertThat(
.updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(null).weight(null)); targetFilterQueryManagement
.updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(null).weight(null)))
.isNotNull();
} }
@Test @Test