From 445c15ac3b55a139e37ddaf5495c262d638067cf Mon Sep 17 00:00:00 2001 From: Avgustin Marinov Date: Sat, 9 Nov 2024 23:41:09 +0200 Subject: [PATCH] Sonar findings - TargetFilterQueryManagementTest fix no assert (#1998) Signed-off-by: Avgustin Marinov --- .../TargetFilterQueryManagementTest.java | 34 +++++++++++++------ 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/management/TargetFilterQueryManagementTest.java b/hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/management/TargetFilterQueryManagementTest.java index 89b99f6b8..3ae3a94e6 100644 --- a/hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/management/TargetFilterQueryManagementTest.java +++ b/hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/management/TargetFilterQueryManagementTest.java @@ -354,10 +354,14 @@ public class TargetFilterQueryManagementTest extends AbstractJpaIntegrationTest final Long filterId = targetFilterQueryManagement .create(entityFactory.targetFilterQuery().create().name("a").query("name==*")).getId(); - targetFilterQueryManagement.create( - entityFactory.targetFilterQuery().create().name("b").query("name==*").autoAssignDistributionSet(ds)); - targetFilterQueryManagement - .updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId())); + assertThat( + targetFilterQueryManagement.create( + entityFactory.targetFilterQuery().create().name("b").query("name==*").autoAssignDistributionSet(ds))) + .isNotNull(); + assertThat( + targetFilterQueryManagement + .updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId()))) + .isNotNull(); } @Test @@ -367,10 +371,15 @@ public class TargetFilterQueryManagementTest extends AbstractJpaIntegrationTest final Long filterId = targetFilterQueryManagement .create(entityFactory.targetFilterQuery().create().name("a").query("name==*")).getId(); - targetFilterQueryManagement.create(entityFactory.targetFilterQuery().create() - .name("b").query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(342)); - targetFilterQueryManagement.updateAutoAssignDS( - entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId()).weight(343)); + assertThat( + targetFilterQueryManagement.create( + entityFactory.targetFilterQuery().create() + .name("b").query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(342))) + .isNotNull(); + assertThat( + targetFilterQueryManagement.updateAutoAssignDS( + entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(ds.getId()).weight(343))) + .isNotNull(); } @Test @@ -378,10 +387,13 @@ public class TargetFilterQueryManagementTest extends AbstractJpaIntegrationTest public void removeDsFromFilterWhenMultiAssignmentModeNotEnabled() { enableMultiAssignments(); final DistributionSet ds = testdataFactory.createDistributionSet(); - final Long filterId = targetFilterQueryManagement.create(entityFactory.targetFilterQuery().create().name("a") + final Long filterId = targetFilterQueryManagement + .create(entityFactory.targetFilterQuery().create().name("a") .query("name==*").autoAssignDistributionSet(ds).autoAssignWeight(23)).getId(); - targetFilterQueryManagement - .updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(null).weight(null)); + assertThat( + targetFilterQueryManagement + .updateAutoAssignDS(entityFactory.targetFilterQuery().updateAutoAssign(filterId).ds(null).weight(null))) + .isNotNull(); } @Test