diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/builder/GridComponentBuilder.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/builder/GridComponentBuilder.java index 39365a831..44e3f2cb8 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/builder/GridComponentBuilder.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/builder/GridComponentBuilder.java @@ -18,6 +18,7 @@ import java.util.stream.Collectors; import org.eclipse.hawkbit.ui.common.data.proxies.ProxyIdentifiableEntity; import org.eclipse.hawkbit.ui.common.data.proxies.ProxyNamedEntity; +import org.eclipse.hawkbit.ui.common.data.proxies.ProxyTarget; import org.eclipse.hawkbit.ui.common.grid.support.DeleteSupport; import org.eclipse.hawkbit.ui.utils.SPUIStyleDefinitions; import org.eclipse.hawkbit.ui.utils.UIMessageIdProvider; @@ -40,6 +41,8 @@ import com.vaadin.ui.themes.ValoTheme; * Builder class for grid components */ public final class GridComponentBuilder { + public static final double DEFAULT_MIN_WIDTH = 100D; + public static final String CREATED_BY_ID = "createdBy"; public static final String CREATED_DATE_ID = "createdDate"; public static final String MODIFIED_BY_ID = "modifiedBy"; @@ -117,7 +120,23 @@ public final class GridComponentBuilder { */ public static Column addNameColumn(final Grid grid, final VaadinMessageSource i18n, final String columnId) { - return addColumn(i18n, grid, E::getName, "header.name", columnId, 100D); + return addColumn(i18n, grid, E::getName, "header.name", columnId, DEFAULT_MIN_WIDTH); + } + + /** + * Add controllerId column to grid + * + * @param grid + * to add the column to + * @param i18n + * message source for internationalization + * @param columnId + * column ID + * @return the created column + */ + public static Column addControllerIdColumn(final Grid grid, + final VaadinMessageSource i18n, final String columnId) { + return addColumn(i18n, grid, ProxyTarget::getControllerId, "header.controllerId", columnId, DEFAULT_MIN_WIDTH); } /** @@ -135,7 +154,7 @@ public final class GridComponentBuilder { */ public static Column addDescriptionColumn(final Grid grid, final VaadinMessageSource i18n, final String columnId) { - return addColumn(i18n, grid, E::getDescription, "header.description", columnId, 100D); + return addColumn(i18n, grid, E::getDescription, "header.description", columnId, DEFAULT_MIN_WIDTH); } /** @@ -152,10 +171,10 @@ public final class GridComponentBuilder { public static List> addCreatedAndModifiedColumns(final Grid grid, final VaadinMessageSource i18n) { final List> columns = new ArrayList<>(); - columns.add(addColumn(i18n, grid, E::getCreatedBy, "header.createdBy", CREATED_BY_ID, 100D)); - columns.add(addColumn(i18n, grid, E::getCreatedDate, "header.createdDate", CREATED_DATE_ID, 100D)); - columns.add(addColumn(i18n, grid, E::getLastModifiedBy, "header.modifiedBy", MODIFIED_BY_ID, 100D)); - columns.add(addColumn(i18n, grid, E::getModifiedDate, "header.modifiedDate", MODIFIED_DATE_ID, 100D)); + columns.add(addColumn(i18n, grid, E::getCreatedBy, "header.createdBy", CREATED_BY_ID, DEFAULT_MIN_WIDTH)); + columns.add(addColumn(i18n, grid, E::getCreatedDate, "header.createdDate", CREATED_DATE_ID, DEFAULT_MIN_WIDTH)); + columns.add(addColumn(i18n, grid, E::getLastModifiedBy, "header.modifiedBy", MODIFIED_BY_ID, DEFAULT_MIN_WIDTH)); + columns.add(addColumn(i18n, grid, E::getModifiedDate, "header.modifiedDate", MODIFIED_DATE_ID, DEFAULT_MIN_WIDTH)); return columns; } @@ -176,7 +195,7 @@ public final class GridComponentBuilder { */ public static Column addVersionColumn(final Grid grid, final VaadinMessageSource i18n, final ValueProvider valueProvider, final String columnId) { - return addColumn(i18n, grid, valueProvider, "header.version", columnId, 100D); + return addColumn(i18n, grid, valueProvider, "header.version", columnId, DEFAULT_MIN_WIDTH); } private static Column addColumn(final VaadinMessageSource i18n, final Grid grid, diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/filtermanagement/TargetFilterTargetGrid.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/filtermanagement/TargetFilterTargetGrid.java index 031416268..2dde8d8b8 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/filtermanagement/TargetFilterTargetGrid.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/filtermanagement/TargetFilterTargetGrid.java @@ -27,6 +27,7 @@ import org.eclipse.hawkbit.ui.utils.UIComponentIdProvider; public class TargetFilterTargetGrid extends AbstractGrid { private static final long serialVersionUID = 1L; + private static final String TARGET_CONTROLLER_ID = "targetControllerId"; private static final String TARGET_NAME_ID = "targetName"; private static final String TARGET_DESCRIPTION_ID = "targetDescription"; private static final String TARGET_STATUS_ID = "targetStatus"; @@ -72,6 +73,8 @@ public class TargetFilterTargetGrid extends AbstractGrid { @Override public void addColumns() { + GridComponentBuilder.addControllerIdColumn(this, i18n, TARGET_CONTROLLER_ID); + GridComponentBuilder.addNameColumn(this, i18n, TARGET_NAME_ID); GridComponentBuilder.addDescriptionColumn(this, i18n, TARGET_DESCRIPTION_ID); @@ -83,4 +86,5 @@ public class TargetFilterTargetGrid extends AbstractGrid { getColumns().forEach(column -> column.setHidable(true)); } + } diff --git a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetGrid.java b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetGrid.java index 80b3adb79..37a0db35e 100644 --- a/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetGrid.java +++ b/hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetGrid.java @@ -73,6 +73,7 @@ public class TargetGrid extends AbstractGrid addControllerIdColumn() { + return GridComponentBuilder.addControllerIdColumn(this, i18n, TARGET_CONTROLLER_ID); + } + private Column addNameColumn() { return GridComponentBuilder.addNameColumn(this, i18n, TARGET_NAME_ID); } @@ -340,6 +345,7 @@ public class TargetGrid extends AbstractGrid { private static final long serialVersionUID = 1L; + private static final String TARGET_CONTROLLER_ID = "targetControllerId"; + private final RolloutManagementUIState rolloutManagementUIState; private final RolloutActionStatusIconSupplier actionStatusIconSupplier; @@ -65,9 +67,11 @@ public class RolloutGroupTargetGrid extends AbstractGrid { @Override public void addColumns() { - GridComponentBuilder.addNameColumn(this, i18n, SPUILabelDefinitions.VAR_NAME).setExpandRatio(3); + GridComponentBuilder.addControllerIdColumn(this, i18n, TARGET_CONTROLLER_ID).setExpandRatio(2); - GridComponentBuilder.addDescriptionColumn(this, i18n, SPUILabelDefinitions.VAR_DESC).setExpandRatio(3); + GridComponentBuilder.addNameColumn(this, i18n, SPUILabelDefinitions.VAR_NAME).setExpandRatio(2); + + GridComponentBuilder.addDescriptionColumn(this, i18n, SPUILabelDefinitions.VAR_DESC).setExpandRatio(2); GridComponentBuilder.addIconColumn(this, actionStatusIconSupplier::getLabel, SPUILabelDefinitions.VAR_STATUS, i18n.getMessage("header.status")); @@ -91,4 +95,5 @@ public class RolloutGroupTargetGrid extends AbstractGrid { public MasterEntitySupport getMasterEntitySupport() { return masterEntitySupport; } + } diff --git a/hawkbit-ui/src/main/resources/messages.properties b/hawkbit-ui/src/main/resources/messages.properties index c7d7cd04d..6b2ced818 100644 --- a/hawkbit-ui/src/main/resources/messages.properties +++ b/hawkbit-ui/src/main/resources/messages.properties @@ -642,6 +642,7 @@ calendar.second=second calendar.seconds=seconds header.name = Name +header.controllerId = Controller ID header.vendor = Vendor header.version = Version header.description = Description