From 1224221e8c8391aefdfd345ae658cbdf2c0da49d Mon Sep 17 00:00:00 2001
From: Michael Hirsch <michael.hirsch@bosch-si.com>
Date: Thu, 28 Jul 2016 10:09:51 +0200
Subject: [PATCH 1/2] sonar pom hygiene

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
---
 pom.xml | 37 +------------------------------------
 1 file changed, 1 insertion(+), 36 deletions(-)

diff --git a/pom.xml b/pom.xml
index 9038d2e56..d78d6d2cc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -127,30 +127,11 @@
       <sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
       <sonar.links.homepage>https://projects.eclipse.org/projects/iot.hawkbit</sonar.links.homepage>
       <sonar.links.ci>https://circleci.com/gh/eclipse/hawkbit</sonar.links.ci>
-      <!-- Jacoco version to use -->
       <jacoco.version>0.7.7.201606060606</jacoco.version>
-      <!-- The Sonar Jacoco Listener for JUnit to extract coverage details
-         per test -->
-      <sonar-jacoco-listeners.version>1.4</sonar-jacoco-listeners.version>
-      <!-- Don't let Sonar execute tests. We will ask it to Maven -->
-      <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
-      <!-- The system property jacoco.outputDir needs to be override on the
-         command line with an absolute path if you want to merge results from all
-         modules. Example in a Jenkisn build where ${WORKSPACE} is defined and your
-         project in the root directory of the workspace : mvn clean install -Prun-its,coverage
-         -Djacoco.outputDir=${WORKSPACE}/target Note that unfortunately using the
-         following does not work because of http://jira.codehaus.org/browse/SONAR-3427:
-         <jacoco.outputDir>${session.executionRootDirectory}/target/</jacoco.outputDir> -->
       <jacoco.outputDir>${project.basedir}/../target/</jacoco.outputDir>
-      <!-- Jacoco output file for UTs -->
       <jacoco.out.ut.file>jacoco-ut.exec</jacoco.out.ut.file>
-      <!-- Tells Sonar where the Jacoco coverage result file is located for
-         Unit Tests -->
       <sonar.jacoco.reportPath>${jacoco.outputDir}/${jacoco.out.ut.file}</sonar.jacoco.reportPath>
-      <!-- Jacoco output file for ITs -->
       <jacoco.out.it.file>jacoco-it.exec</jacoco.out.it.file>
-      <!-- Tells Sonar where the Jacoco coverage result file is located for
-         Integration Tests -->
       <sonar.jacoco.itReportPath>${jacoco.outputDir}/${jacoco.out.it.file}</sonar.jacoco.itReportPath>
       <!-- Sonar - END-->
    </properties>
@@ -295,7 +276,6 @@
                   <forkCount>1</forkCount>
                   <argLine>
                      ${jacoco.agent.ut.arg}
-                     -javaagent:"${settings.localRepository}/org/aspectj/aspectjweaver/${aspectj.version}/aspectjweaver-${aspectj.version}.jar"
                   </argLine>
                   <properties>
                      <property>
@@ -312,13 +292,6 @@
                      <exclude>**/Abstract*.java</exclude>
                   </excludes>
                </configuration>
-               <dependencies>
-                  <dependency>
-                     <groupId>org.aspectj</groupId>
-                     <artifactId>aspectjweaver</artifactId>
-                     <version>${aspectj.version}</version>
-                  </dependency>
-               </dependencies>
             </plugin>
             <plugin>
                <groupId>org.apache.maven.plugins</groupId>
@@ -326,8 +299,7 @@
                <configuration>
                   <reuseForks>true</reuseForks>
                   <forkCount>3</forkCount>
-                  <argLine>-Xmx1024m ${jacoco.agent.ut.arg}
-                     -javaagent:"${settings.localRepository}/org/aspectj/aspectjweaver/${aspectj.version}/aspectjweaver-${aspectj.version}.jar"</argLine>
+                  <argLine>-Xmx1024m ${jacoco.agent.ut.arg}</argLine>
                   <properties>
                      <property>
                         <name>listener</name>
@@ -335,13 +307,6 @@
                      </property>
                   </properties>
                </configuration>
-               <dependencies>
-                  <dependency>
-                     <groupId>org.aspectj</groupId>
-                     <artifactId>aspectjweaver</artifactId>
-                     <version>${aspectj.version}</version>
-                  </dependency>
-               </dependencies>
                <executions>
                   <execution>
                      <id>integration-test</id>

From 271ee88d1242259287f231ad5b6a292cadaa8a3a Mon Sep 17 00:00:00 2001
From: Michael Hirsch <michael.hirsch@bosch-si.com>
Date: Thu, 28 Jul 2016 10:38:29 +0200
Subject: [PATCH 2/2] remove unnecessary property declaration

Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
---
 pom.xml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index d78d6d2cc..8426b9740 100644
--- a/pom.xml
+++ b/pom.xml
@@ -100,7 +100,6 @@
       <org.powermock.version>1.5.4</org.powermock.version>
       <pl.pragmatists.version>1.0.2</pl.pragmatists.version>
       <json-path.version>0.9.1</json-path.version>
-      <aspectj.version>1.8.5</aspectj.version>
       <guava.version>19.0</guava.version>
       <mariadb-java-client.version>1.4.3</mariadb-java-client.version>
       <embedded-mongo.version>1.50.2</embedded-mongo.version>
@@ -124,7 +123,6 @@
       <!-- Sonar - START-->
       <sonar.host.url>https://sonar.eu-gb.mybluemix.net</sonar.host.url>
       <sonar.github.repository>eclipse/hawkbit</sonar.github.repository>
-      <sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
       <sonar.links.homepage>https://projects.eclipse.org/projects/iot.hawkbit</sonar.links.homepage>
       <sonar.links.ci>https://circleci.com/gh/eclipse/hawkbit</sonar.links.ci>
       <jacoco.version>0.7.7.201606060606</jacoco.version>