lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix xss remained parts (#947)

Browse Source 
* Fix remained XSS related tooltips by disabling them
* Adding TODOs to tooltips which has been set to null because of XSS
* Removing TODOs because of SonarQube

Signed-off-by: Ammar Bikic <ammar.bikic@bosch-si.com>
This commit is contained in:
amic
2020-03-17 07:53:32 +01:00
committed by GitHub
parent 7cf41c9a28
commit 2dc5a959f0
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/AbstractMetadataDetailsLayout.java
View File

@@ -81,8 +81,9 @@ public abstract class AbstractMetadataDetailsLayout extends Table {
} }
private Button customMetadataDetailButton(final String metadataKey) { private Button customMetadataDetailButton(final String metadataKey) {
//After Vaadin 8 migration: Enable tooltip again, currently it is set to [null] to avoid cross site scripting.
final Button viewIcon = SPUIComponentProvider.getButton(getDetailLinkId(metadataKey), metadataKey, final Button viewIcon = SPUIComponentProvider.getButton(getDetailLinkId(metadataKey), metadataKey,
"View " + metadataKey + " Metadata details", null, false, null, SPUIButtonStyleNoBorder.class); null, null, false, null, SPUIButtonStyleNoBorder.class);
viewIcon.setData(metadataKey); viewIcon.setData(metadataKey);
viewIcon.addStyleName(ValoTheme.BUTTON_TINY + " " + ValoTheme.BUTTON_LINK + " " + "on-focus-no-border link" viewIcon.addStyleName(ValoTheme.BUTTON_TINY + " " + ValoTheme.BUTTON_LINK + " " + "on-focus-no-border link"
+ " " + "text-style"); + " " + "text-style");

3
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetDetails.java
View File

@@ -266,7 +266,8 @@ public class TargetDetails extends AbstractTableDetailsLayout<Target> {
sortedAttributes.forEach((key, value) -> { sortedAttributes.forEach((key, value) -> {
final HorizontalLayout conAttributeLayout = SPUIComponentProvider.createNameValueLayout(key.concat(" : "), final HorizontalLayout conAttributeLayout = SPUIComponentProvider.createNameValueLayout(key.concat(" : "),
value == null ? "" : value); value == null ? "" : value);
conAttributeLayout.setDescription(key.concat(" : ") + value); //After Vaadin 8 migration: Enable tooltip again, currently it is set to [null] to avoid cross site scripting.
conAttributeLayout.setDescription(null);
conAttributeLayout.addStyleName("label-style"); conAttributeLayout.addStyleName("label-style");
attributesLayout.addComponent(conAttributeLayout); attributesLayout.addComponent(conAttributeLayout);
}); });

3
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettag/filter/TargetFilterQueryButtons.java
View File

@@ -130,7 +130,8 @@ public class TargetFilterQueryButtons extends Table {
if (id != null) { if (id != null) {
button.setCaption(name); button.setCaption(name);
} }
button.setDescription(name); //After Vaadin 8 migration: Enable tooltip again, currently it is set to [null] to avoid cross site scripting.
button.setDescription(null);
button.setData(itemId); button.setData(itemId);
button.addClickListener(event -> customTargetTagFilterButtonClick.processButtonClick(event)); button.addClickListener(event -> customTargetTagFilterButtonClick.processButtonClick(event));
return button; return button;