Found even more code that could be deleted

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/Action.java

@@ -264,9 +264,6 @@ public class Action extends TenantAwareBaseEntity implements Comparable<Action>
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/ActionStatus.java

@@ -150,9 +150,6 @@ public class ActionStatus extends TenantAwareBaseEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/ActionWithStatusCount.java

@@ -86,93 +86,54 @@ public class ActionWithStatusCount {
         action.setId(actionId);
     }
 
-    /**
-     * @return the action
-     */
     public Action getAction() {
         return action;
     }
 
-    /**
-     * @return the actionId
-     */
     public Long getActionId() {
         return actionId;
     }
 
-    /**
-     * @return the actionType
-     */
     public ActionType getActionType() {
         return actionType;
     }
 
-    /**
-     * @return the actionActive
-     */
     public boolean isActionActive() {
         return actionActive;
     }
 
-    /**
-     * @return the actionForceTime
-     */
     public long getActionForceTime() {
         return actionForceTime;
     }
 
-    /**
-     * @return the actionStatus
-     */
     public Status getActionStatus() {
         return actionStatus;
     }
 
-    /**
-     * @return the actionCreatedAt
-     */
     public Long getActionCreatedAt() {
         return actionCreatedAt;
     }
 
-    /**
-     * @return the actionLastModifiedAt
-     */
     public Long getActionLastModifiedAt() {
         return actionLastModifiedAt;
     }
 
-    /**
-     * @return the dsId
-     */
     public Long getDsId() {
         return dsId;
     }
 
-    /**
-     * @return the dsName
-     */
     public String getDsName() {
         return dsName;
     }
 
-    /**
-     * @return the dsVersion
-     */
     public String getDsVersion() {
         return dsVersion;
     }
 
-    /**
-     * @return the actionStatusCount
-     */
     public Long getActionStatusCount() {
         return actionStatusCount;
     }
 
-    /**
-     * @return the rolloutName
-     */
     public String getRolloutName() {
         return rolloutName;
     }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/Artifact.java

@@ -64,9 +64,6 @@ public abstract class Artifact extends TenantAwareBaseEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/BaseEntity.java

@@ -154,7 +154,7 @@ public abstract class BaseEntity implements Serializable, Identifiable<Long> {
         if (obj == null) {
             return false;
         }
-        if (getClass() != obj.getClass()) {
+        if (!(obj instanceof BaseEntity)) {
             return false;
         }
         final BaseEntity other = (BaseEntity) obj;

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSet.java

@@ -135,23 +135,14 @@ public class DistributionSet extends NamedVersionedEntity {
         return tags;
     }
 
-    /**
-     * @return the deleted
-     */
     public boolean isDeleted() {
         return deleted;
     }
 
-    /**
-     * @return the metadata
-     */
     public List<DistributionSetMetadata> getMetadata() {
         return metadata;
     }
 
-    /**
-     * @return the actions
-     */
     public List<Action> getActions() {
         return actions;
     }
@@ -166,9 +157,6 @@ public class DistributionSet extends NamedVersionedEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSetTag.java

@@ -74,9 +74,6 @@ public class DistributionSetTag extends Tag {
 
     @Override
     public boolean equals(final Object obj) { // NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSetType.java

@@ -295,9 +295,6 @@ public class DistributionSetType extends NamedEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSetTypeElement.java

@@ -71,30 +71,18 @@ public class DistributionSetTypeElement implements Serializable {
         this.mandatory = mandatory;
     }
 
-    /**
-     * @return the mandatory
-     */
     public boolean isMandatory() {
         return mandatory;
     }
 
-    /**
-     * @return the dsType
-     */
     public DistributionSetType getDsType() {
         return dsType;
     }
 
-    /**
-     * @return the smType
-     */
     public SoftwareModuleType getSmType() {
         return smType;
     }
 
-    /**
-     * @return the key
-     */
     public DistributionSetTypeElementCompositeKey getKey() {
         return key;
     }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/ExternalArtifact.java

@@ -81,18 +81,11 @@ public class ExternalArtifact extends Artifact {
         return softwareModule;
     }
 
-    /**
-     * @param softwareModule
-     *            the softwareModule to set
-     */
     public final void setSoftwareModule(final SoftwareModule softwareModule) {
         this.softwareModule = softwareModule;
         this.softwareModule.addArtifact(this);
     }
 
-    /**
-     * @return the externalArtifactProvider
-     */
     public ExternalArtifactProvider getExternalArtifactProvider() {
         return externalArtifactProvider;
     }
@@ -101,17 +94,10 @@ public class ExternalArtifact extends Artifact {
         return new StringBuilder().append(externalArtifactProvider.getBasePath()).append(urlSuffix).toString();
     }
 
-    /**
-     * @return the urlSuffix
-     */
     public String getUrlSuffix() {
         return urlSuffix;
     }
 
-    /**
-     * @param externalArtifactProvider
-     *            the externalArtifactProvider to set
-     */
     public void setExternalArtifactProvider(final ExternalArtifactProvider externalArtifactProvider) {
         this.externalArtifactProvider = externalArtifactProvider;
     }
@@ -134,9 +120,6 @@ public class ExternalArtifact extends Artifact {
 
     @Override
     public boolean equals(final Object obj) { // NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/ExternalArtifactProvider.java

@@ -83,9 +83,6 @@ public class ExternalArtifactProvider extends NamedEntity {
 
     @Override
     public boolean equals(final Object obj) { // NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/LocalArtifact.java

@@ -83,9 +83,6 @@ public class LocalArtifact extends Artifact {
 
     @Override
     public boolean equals(final Object obj) { // NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/NamedEntity.java

@@ -71,9 +71,6 @@ public abstract class NamedEntity extends TenantAwareBaseEntity {
 
     @Override
     public boolean equals(final Object obj) { // NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/NamedVersionedEntity.java

@@ -58,9 +58,6 @@ public abstract class NamedVersionedEntity extends NamedEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/Rollout.java

@@ -242,9 +242,6 @@ public class Rollout extends NamedEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/RolloutGroup.java

@@ -487,9 +487,6 @@ public class RolloutGroup extends NamedEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/RolloutTargetGroupId.java

@@ -13,13 +13,8 @@ import java.io.Serializable;
 /**
  * Combined unique key of the table {@link RolloutTargetGroup}.
  *
- * @author Michael Hirsch
- *
  */
 public class RolloutTargetGroupId implements Serializable {
-    /**
-     * 
-     */
     private static final long serialVersionUID = 1L;
 
     private Long rolloutGroup;

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/SoftwareModule.java

@@ -208,17 +208,10 @@ public class SoftwareModule extends NamedVersionedEntity {
         return type;
     }
 
-    /**
-     * @return the deleted
-     */
     public boolean isDeleted() {
         return deleted;
     }
 
-    /**
-     * @param deleted
-     *            the deleted to set
-     */
     public void setDeleted(final boolean deleted) {
         this.deleted = deleted;
     }
@@ -227,9 +220,6 @@ public class SoftwareModule extends NamedVersionedEntity {
         this.type = type;
     }
 
-    /**
-     * @return the metadata
-     */
     public List<SoftwareModuleMetadata> getMetadata() {
         return metadata;
     }
@@ -250,9 +240,6 @@ public class SoftwareModule extends NamedVersionedEntity {
 
     @Override
     public boolean equals(final Object obj) { // NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/SoftwareModuleType.java

@@ -125,9 +125,6 @@ public class SoftwareModuleType extends NamedEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/Tag.java

@@ -67,9 +67,6 @@ public abstract class Tag extends NamedEntity implements Identifiable<Long> {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/Target.java

@@ -139,13 +139,10 @@ public class Target extends NamedEntity implements Persistable<Long> {
      */
     @Override
     public boolean equals(final Object obj) {// NOSONAR - as this is generated
-        if (this == obj) {
-            return true;
-        }
         if (obj == null) {
             return false;
         }
-        if (getClass() != obj.getClass()) {
+        if (!(obj instanceof Target)) {
             return false;
         }
         final Target other = (Target) obj;

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TargetFilterQuery.java

@@ -66,9 +66,6 @@ public class TargetFilterQuery extends TenantAwareBaseEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TargetTag.java

@@ -74,9 +74,6 @@ public class TargetTag extends Tag {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TargetWithActionStatus.java

@@ -30,32 +30,18 @@ public class TargetWithActionStatus {
         this.target = target;
     }
 
-    /**
-     * @return the target
-     */
     public Target getTarget() {
         return target;
     }
 
-    /**
-     * @return the status
-     */
     public Status getStatus() {
         return status;
     }
 
-    /**
-     * @param target
-     *            the target to set
-     */
     public void setTarget(final Target target) {
         this.target = target;
     }
 
-    /**
-     * @param status
-     *            the status to set
-     */
     public void setStatus(final Status status) {
         this.status = status;
     }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TenantAwareBaseEntity.java

@@ -101,9 +101,6 @@ public abstract class TenantAwareBaseEntity extends BaseEntity {
      */
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TenantConfiguration.java

@@ -92,9 +92,6 @@ public class TenantConfiguration extends TenantAwareBaseEntity implements Serial
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }

hawkbit-repository/src/main/java/org/eclipse/hawkbit/repository/model/TenantMetaData.java

@@ -88,9 +88,6 @@ public class TenantMetaData extends BaseEntity {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
         if (!super.equals(obj)) {
             return false;
         }