lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

avoid more than 3 nested if/switch/try blocks

Browse Source 
Signed-off-by: Michael Hirsch <michael.hirsch@bosch-si.com>
This commit is contained in:
Michael Hirsch
2016-07-25 11:18:05 +02:00
parent 40a12c0321
commit 227267af88
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
hawkbit-security-core/src/main/java/org/eclipse/hawkbit/im/authentication/SpPermission.java
View File

@@ -185,18 +185,22 @@ public final class SpPermission {
field.setAccessible(true); field.setAccessible(true);
try { try {
final String role = (String) field.get(null); final String role = (String) field.get(null);
if (!(exclusionRoles.contains(role))) { addIfNotExcluded(exclusionRoles, allPermissions, role);
allPermissions.add(role);
}
} catch (final IllegalAccessException e) { } catch (final IllegalAccessException e) {
LOGGER.error(e.getMessage(), e); LOGGER.error(e.getMessage(), e);
} }
} }
} }
return allPermissions; return allPermissions;
} }
private static void addIfNotExcluded(final Collection<String> exclusionRoles, final List<String> allPermissions,
final String role) {
if (!(exclusionRoles.contains(role))) {
allPermissions.add(role);
}
}
/** /**
* Contains all the spring security evaluation expressions for the * Contains all the spring security evaluation expressions for the
* {@link PreAuthorize} annotation for method security. * {@link PreAuthorize} annotation for method security.