lingwei.kong/hawkbit
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix failing ControllerManagement tests (#856)

Browse Source 
Signed-off-by: Stefan Behl <stefan.behl@bosch-si.com>
This commit is contained in:
Stefan Behl
2019-06-19 16:48:07 +02:00
committed by GitHub
parent f6c0edffa5
commit 06a739a3dc
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
hawkbit-repository/hawkbit-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
View File

@@ -531,7 +531,7 @@ public class ControllerManagementTest extends AbstractJpaIntegrationTest {
assertThatExceptionOfType(ConstraintViolationException.class) assertThatExceptionOfType(ConstraintViolationException.class)
.isThrownBy(() -> controllerManagement.findOrRegisterTargetIfItDoesNotExist( .isThrownBy(() -> controllerManagement.findOrRegisterTargetIfItDoesNotExist(
RandomStringUtils.random(Target.CONTROLLER_ID_MAX_SIZE + 1), LOCALHOST)) RandomStringUtils.randomAlphabetic(Target.CONTROLLER_ID_MAX_SIZE + 1), LOCALHOST))
.as("register target with too long controllerId should fail"); .as("register target with too long controllerId should fail");
} }
@@ -561,7 +561,7 @@ public class ControllerManagementTest extends AbstractJpaIntegrationTest {
@Expect(type = TargetPollEvent.class, count = 1)}) @Expect(type = TargetPollEvent.class, count = 1)})
public void findOrRegisterTargetIfItDoesNotExistDoesNotThrowExceptionBeforeMaxRetries() { public void findOrRegisterTargetIfItDoesNotExistDoesNotThrowExceptionBeforeMaxRetries() {
TargetRepository mockTargetRepository = Mockito.mock(TargetRepository.class); final TargetRepository mockTargetRepository = Mockito.mock(TargetRepository.class);
((JpaControllerManagement) controllerManagement).setTargetRepository(mockTargetRepository); ((JpaControllerManagement) controllerManagement).setTargetRepository(mockTargetRepository);
final Target target = testdataFactory.createTarget(); final Target target = testdataFactory.createTarget();
@@ -586,7 +586,7 @@ public class ControllerManagementTest extends AbstractJpaIntegrationTest {
+ "exception is rethrown and no further retries will be attempted") + "exception is rethrown and no further retries will be attempted")
public void findOrRegisterTargetIfItDoesNotExistDoesntRetryWhenEntityAlreadyExistsException() { public void findOrRegisterTargetIfItDoesNotExistDoesntRetryWhenEntityAlreadyExistsException() {
TargetRepository mockTargetRepository = Mockito.mock(TargetRepository.class); final TargetRepository mockTargetRepository = Mockito.mock(TargetRepository.class);
((JpaControllerManagement) controllerManagement).setTargetRepository(mockTargetRepository); ((JpaControllerManagement) controllerManagement).setTargetRepository(mockTargetRepository);
when(mockTargetRepository.findOne(any())).thenReturn(Optional.empty()); when(mockTargetRepository.findOne(any())).thenReturn(Optional.empty());
@@ -595,7 +595,7 @@ public class ControllerManagementTest extends AbstractJpaIntegrationTest {
try { try {
controllerManagement.findOrRegisterTargetIfItDoesNotExist("1234", LOCALHOST); controllerManagement.findOrRegisterTargetIfItDoesNotExist("1234", LOCALHOST);
fail("Expected an EntityAlreadyExistsException to be thrown!"); fail("Expected an EntityAlreadyExistsException to be thrown!");
} catch (EntityAlreadyExistsException e) { } catch (final EntityAlreadyExistsException e) {
verify(mockTargetRepository, times(1)).findOne(any()); verify(mockTargetRepository, times(1)).findOne(any());
verify(mockTargetRepository, times(1)).save(any()); verify(mockTargetRepository, times(1)).save(any());
} finally { } finally {
@@ -609,7 +609,7 @@ public class ControllerManagementTest extends AbstractJpaIntegrationTest {
+ "rethrown") + "rethrown")
public void recoverFindOrRegisterTargetIfItDoesNotExistIsNotInvokedForOtherExceptions() { public void recoverFindOrRegisterTargetIfItDoesNotExistIsNotInvokedForOtherExceptions() {
TargetRepository mockTargetRepository = Mockito.mock(TargetRepository.class); final TargetRepository mockTargetRepository = Mockito.mock(TargetRepository.class);
((JpaControllerManagement) controllerManagement).setTargetRepository(mockTargetRepository); ((JpaControllerManagement) controllerManagement).setTargetRepository(mockTargetRepository);
when(mockTargetRepository.findOne(any())).thenThrow(RuntimeException.class); when(mockTargetRepository.findOne(any())).thenThrow(RuntimeException.class);
@@ -617,7 +617,7 @@ public class ControllerManagementTest extends AbstractJpaIntegrationTest {
try { try {
controllerManagement.findOrRegisterTargetIfItDoesNotExist("aControllerId", LOCALHOST); controllerManagement.findOrRegisterTargetIfItDoesNotExist("aControllerId", LOCALHOST);
fail("Expected a RuntimeException to be thrown!"); fail("Expected a RuntimeException to be thrown!");
} catch (RuntimeException e) { } catch (final RuntimeException e) {
verify(mockTargetRepository, times(1)).findOne(any()); verify(mockTargetRepository, times(1)).findOne(any());
} finally { } finally {
// revert // revert